Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 201125: Use a better highlight images for extension toolstrip (Closed)

Created:
11 years, 3 months ago by Finnur
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org, Ben Goodger (Google)
Visibility:
Public.

Description

Use a better highlight images for "hover" state and pushed "state". BUG=18452 TEST=Try different themes and make sure the extension toolstrips have a nice hover and "pushed" images (by hovering over and then clicking and holding the left mouse button). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26287

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/extensions_toolstrip.css View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
11 years, 3 months ago (2009-09-15 22:39:32 UTC) #1
Erik does not do reviews
11 years, 3 months ago (2009-09-15 22:42:28 UTC) #2
LGTM - rubberstamp

On Tue, Sep 15, 2009 at 3:39 PM,  <finnur@chromium.org> wrote:
> Reviewers: Erik Kay,
>
> Description:
> Use a better highlight images for "hover" state and pushed "state".
>
> BUG=3D18452
> TEST=3DTry different themes and make sure the extension toolstrips have a=
 nice
> hover and "pushed" images (by hovering over and then clicking and holding
> the
> left mouse button).
>
>
> Please review this at http://codereview.chromium.org/201125
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 chrome/browser/browser_resources.grd
> =A0M =A0 =A0 chrome/browser/resources/extensions_toolstrip.css
>
>
> Index: chrome/browser/resources/extensions_toolstrip.css
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- chrome/browser/resources/extensions_toolstrip.css =A0 (revision 26227=
)
> +++ chrome/browser/resources/extensions_toolstrip.css =A0 (working copy)
> @@ -86,10 +86,10 @@
> =A0*/
> =A0div.toolstrip-button:hover {
> =A0 border-width:6px;
> -
> =A0-webkit-border-image:url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgA=
AAA4AAAAaCAYAAACHD21cAAAAAXNSR0IArs4c6QAAAAZiS0dEAPYA+QD9Ry7YfAAAAAlwSFlzAA=
ALEwAACxMBAJqcGAAAAAd0SU1FB9kJChUuJy+ouI4AAAFXSURBVDjL7dSxTsJQFIDh/95SmqpEY=
jASAgPGGI26wGv4BMbBVUZewBQfRBxAZ0cXG2d8AANoFEJgAGOAkqK31wEGJ23cTPiTs53vjEcA=
Yj5RYAmwgAjQYlYG+AR8wAOmgAaQwLLjlHL1RrM4HI0rKtA1z1c1z1c1FejacDSu1BvNouOUcsA=
yIA3AcpzS7mmhcJxKpQ4Nw0yoQM9OAirQSCOSiMfjB3t7+6ux2ErHdd2BANbqjeZJNps9UsFs8a=
deX56rO9tbZQlYyWQyH4RAAIn1jTxgScCwbXsz0L8jANu2NwEjArSnn9okZEIIE2hL/tgCLuB/g=
uloRHyEBVrrDyAtATWZTJ7CwvmukoDf7XYfpAgHe73uA+BLwKtWKu7bYHD/Gxr0+/fXV1UX8Awg=
cN2791hspZPJZIZm1Iqappn4DjzPe2y3W7eX5Yubc+fsEfDFXx/yF0HjkTNryckZAAAAAElFTkS=
uQmCC)
> 6 round round;
> +
> =A0-webkit-border-image:url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgA=
AAA4AAAAaCAYAAACHD21cAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAV=
RJREFUeNpi/P//PwMjIyMfAwODEhsbmworKxvD79+/GED0jx/fGf7+/csABT+A+B4Q3wLq+cME0=
sTMzOzW1dOncuX6bYZnL98wvH73CUy/+/iV4eOXH2B86+5DjoLCYi2gxgCwHiBDs7O7Vyg9I4uB=
h4eHARcAyTk6OTMICQkx7N61U5kJKCZqY2PLQCyAqv3ICCSCgE5jAvqPKI2/fv1iEBXiYwDZSLQ=
mEACpBYYJWCNZgCyNoChi4uTkpJ+N9NdIdqhycHCSpxGUCcj3IygJkQpAWY6k5AbPmMB8yvT9+3=
f6BQ7YRrKTHMijZCVyUJyQGrLglAPSffvWTaI13bhxHWIj0LbLq1auIFoj1JKnoFLu44kTxzVAh=
Y+goCCDmJg4TpuWL1vKkJOV8RTIvcsILZA5QAUy0O1aoDgC+RuWQkDg69cvIOoTEL8AFcpAPV8A=
AgwAn6qHYvNUlBEAAAAASUVORK5CYII=3D)
> 6 round round;
> =A0}
>
> =A0div.toolstrip-button:active {
> =A0 border-width:6px;
> -
> =A0-webkit-border-image:url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgA=
AAA4AAAAaCAYAAACHD21cAAAAAXNSR0IArs4c6QAAAAZiS0dEAPYA+QD9Ry7YfAAAAAlwSFlzAA=
ALEwAACxMBAJqcGAAAAAd0SU1FB9kJChYWGmIZ9j0AAAGzSURBVDjLnZTBahNRFIa/c2+SyaRWB=
zddiBVCQ0Hqou67yCbgQnyC7NyluPUhHBCJeQLBVxDBbXwACY271iKBQBHbJE0nM3OPi9Q2qYqT=
+VeHyznn/89/7r2WBRhjSqpaBgTwgRRQ/gIB6HQ6prq1/ebx7u7+zQTVedbkfMLR4eHLrwe9V61=
WSwXgw8dP7Z1HO/t3bgfX7ZSlWFVJkoRe78vbOJq+KABsbj7YK3v+Ag1/xCJCsVikWt3au39vY8=
74fTCM1m6tl6wxS/lyo4cAzrlZp/26bACMtSURIQtETMnzvAWKjLhSDjAYnmilsoZZYP2nVIVgv=
Szmcl+ZIUAYhiKAPxienOdhzIVc5oRhmMNVpwD+6lLnPsSrF+r1jFGOyqIBvByEkQGmOaR6udYh=
ItOVr9z8V1DJO6MzQRBEUexms0Qzsjl837em2Wym4/G475zLVBhdTA9qtVpq2u327Pjb8fs0Sf/=
7MqJYOTs77TcaDbUAz54++awioqZ0V2xxI3UQp0qSKmmqJE4ZTyb9058/3j3crj6/+ld/o9vt2t=
FoVLHWXlweeQCFQmFSr9eXTPgFRPyveVqGdF0AAAAASUVORK5CYII=3D)
> 6 round round;
> +
> =A0-webkit-border-image:url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgA=
AAA4AAAAaCAYAAACHD21cAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAb=
hJREFUeNqcVDtPwmAU/R6tCUZsIw5AKODoYNREBNREiAb9t+qoRmDxBYOYOGGiVAexaGzDUJK2X=
70fFURjUtuztfeennMfvdh1XTTCer5AKKUEY8zgkULMvrw4/06YAObE3Hoep1KppWx2YVqSZQTk=
cbLjOJgxhnX9Az0+PLx3uy/tZqOBBB5MJpNLO7sVobK3/yZJEotEIj9UTNPEmvZK67Va9PTkeHl=
lZfWW8EBKUaa2S6V+PB53fpM4+LtMJmuXyuW+klbEVusGDYmxuZggSTJDPuA5PDdfKHpE6AiSZX=
8iz+G5hBBMUEB8NQ4LEw//BoyIkY3NLRqExMdT3Nj0xhEUoIgIColQzQGrOJQi7DINa5WFrxH+D=
haGR8I0aGgVZuKEVQwMKM8JvHJjST4TSgU3qCiBe+IMBibRdd3XNj8hlmXxSRBi27bb62msp2m+=
lg3DIIau2yDGSLNxzZ5UVa/Xq7P37bbIv/qXkqp2hOrZafT5+Qk1rq+887iWy6FEIrmYzmRmYrF=
5QRRF5i20VzuUQuE82mqnYx4dHtyN7+oI/L4KAGiYM1pmHgdn1tXlxQ8XnwIMABNlyWs2CMVlAA=
AAAElFTkSuQmCC)
> 6 round round;
> =A0}
> Index: chrome/browser/browser_resources.grd
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- chrome/browser/browser_resources.grd =A0 =A0 =A0 =A0(revision 26227)
> +++ chrome/browser/browser_resources.grd =A0 =A0 =A0 =A0(working copy)
> @@ -1,6 +1,6 @@
> =A0<?xml version=3D"1.0" encoding=3D"UTF-8"?>
> =A0<!-- This comment is only here because changes to resources are not pi=
cked
> up
> -without changes to the corresponding grd file. fb01 -->
> +without changes to the corresponding grd file. fb03 -->
> =A0<grit latest_public_release=3D"0" current_release=3D"1">
> =A0 <outputs>
> =A0 =A0 <output filename=3D"grit/browser_resources.h" type=3D"rc_header">
>
>
>

Powered by Google App Engine
This is Rietveld 408576698