Issue 201122: Changes needed for MacOS X 10.4 support....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 201122: Changes needed for MacOS X 10.4 support.... (Closed)

Created:
11 years, 3 months ago by maf

Modified:
9 years, 7 months ago

Reviewers:
Greg Spencer

CC:
chromium-reviews_googlegroups.com, John Grabowski, brettw, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Changes needed for MacOS X 10.4 support. Add "support_macosx_10_4" option to common.gypi that causes it to change deployment target, and define a new preprocessor symbol on the Mac build. Setting this flag to true is harmless on non Mac builds and has no effect. Make various changes to source files where they modify their behavior in the presence of the new preprocessor symbol to become 10.4 compatible. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26285

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -22 lines)			Patch
A	base/compat_execinfo.h	View	1 2	1 chunk	+29 lines, -0 lines	0 comments	Download
M	base/debug_util_posix.cc	View	1	3 chunks	+27 lines, -19 lines	0 comments	Download
M	base/file_util_posix.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	build/common.gypi	View	1	2 chunks	+21 lines, -1 line	0 comments	Download
M	o3d/DEPS_gyp	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 3 months ago (2009-09-16 13:57:16 UTC) #2

hbono@chromium.org wrote:
> This macro has been added by the original change that caused this build
> break: <http://codereview.chromium.org/201122> "Changes needed for MacOS
> X 10.4 support". Even though I'm not sure the real usage of this macro,
> it seems to be used for enclosing Tiger-specific code.

OK, thanks for the information.  The GYP variable
(support_macosx_10_4) is fine, but we should not define our own macro
for this.  Once we tell the compiler that the deployment target is
10.4, it will define a macro for us, and we should use it.  In this
case, instead of SUPPORT_MAC_OS_X_10_4, we should use:

#if MAC_OS_X_VERSION_MIN_REQUIRED <= MAC_OS_X_VERSION_10_4

Since there are no Mac OS X framework headers included here, the file
that makes this check must also:

#include <AvailabilityMacros.h>

You may do this in your change now, and we can get rid of
SUPPORT_MAC_OS_X_10_4 separately.

Mark

Expand Messages | Collapse Messages