Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 201118: Merge r2895 from bleeding_edge to trunk (Closed)

Created:
11 years, 3 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
iposva
CC:
v8-dev
Visibility:
Public.

Description

Merge r2895 from bleeding_edge to trunk for immediate use by Chromium. Remove explicit include of Chromium's common.gypi from v8.gyp. Explicit includes of common.gypi are being deprecated. Chromium will include the .gypi files that it needs by asking GYP to force-include them into each .gyp file that it loads. See http://codereview.chromium.org/206006. Committed: http://code.google.com/p/v8/source/detail?r=2896

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
MM tools/gyp/v8.gyp View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
11 years, 3 months ago (2009-09-15 18:09:01 UTC) #1
iposva
11 years, 3 months ago (2009-09-15 18:21:15 UTC) #2
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698