Issue 201115: Cause experimental builds to delete profile information on uninstall.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 201115: Cause experimental builds to delete profile information on uninstall. (Closed)

Created:
11 years, 3 months ago by robertshield

Modified:
9 years, 6 months ago

Reviewers:
kuchhal

CC:
chromium-reviews_googlegroups.com, kuchhal

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Cause experimental builds to delete profile information on uninstall. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26226

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/installer/setup/install.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kuchhal

11 years, 3 months ago (2009-09-15 16:32:24 UTC) #2

lgtm.

On Tue, Sep 15, 2009 at 8:30 AM, <robertshield@chromium.org> wrote:

> Reviewers: kuchhal,
>
> Description:
> Cause experimental builds to delete profile information on uninstall.
>
>
> Please review this at http://codereview.chromium.org/201115
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/installer/setup/install.cc
>
>
> Index: chrome/installer/setup/install.cc
> ===================================================================
> --- chrome/installer/setup/install.cc   (revision 26212)
> +++ chrome/installer/setup/install.cc   (working copy)
> @@ -98,6 +98,8 @@
>  #ifdef CHROME_EXP_BUILD
>   uninstall_cmd.append(L" --");
>   uninstall_cmd.append(installer_util::switches::kForceUninstall);
> +  uninstall_cmd.append(L" --");
> +  uninstall_cmd.append(installer_util::switches::kDeleteProfile);
>  #endif
>
>   if (reg_root == HKEY_LOCAL_MACHINE) {
> @@ -247,6 +249,8 @@
>  #ifdef CHROME_EXP_BUILD
>     arguments.append(L" --");
>     arguments.append(installer_util::switches::kForceUninstall);
> +    arguments.append(L" --");
> +    arguments.append(installer_util::switches::kDeleteProfile);
>  #endif
>
>     if (system_install) {
>
>
>

Expand Messages | Collapse Messages