Issue 201079: Lands http://codereview.chromium.org/194014 for Oshima:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 201079: Lands http://codereview.chromium.org/194014 for Oshima:... (Closed)

Created:
11 years, 3 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Lands http://codereview.chromium.org/194014 for Oshima: * enable MessageBoxView convert wstring to string16 when necessary using WideToUTF16Hack, which is no-op on Windows. * updated checkbox to get state update working state handing is a bit hacky, esp. b/c gtk sends signal even when the state is changed via API. If there is better way, please let me know. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25896

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -9 lines)			Patch
M	views/controls/button/native_button_gtk.h	View	2 chunks	+18 lines, -3 lines	0 comments	Download
M	views/controls/button/native_button_gtk.cc	View	2 chunks	+43 lines, -2 lines	0 comments	Download
M	views/controls/message_box_view.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	views/views.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download