Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 194014: * enable message box... (Closed)

Created:
11 years, 3 months ago by oshima
Modified:
9 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

* enable MessageBoxView convert wstring to string16 when necessary using WideToUTF16Hack, which is no-op on Windows. * updated checkbox to get state update working state handing is a bit hacky, esp. b/c gtk sends signal even when the state is changed via API. If there is better way, please let me know.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 7

Patch Set 4 : * enable MessageBoxView... #

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -9 lines) Patch
M views/controls/button/native_button_gtk.h View 1 2 3 4 2 chunks +18 lines, -3 lines 0 comments Download
M views/controls/button/native_button_gtk.cc View 1 2 3 4 2 chunks +43 lines, -2 lines 0 comments Download
M views/controls/message_box_view.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M views/views.gyp View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
oshima
11 years, 3 months ago (2009-09-03 21:50:18 UTC) #1
sky
http://codereview.chromium.org/194014/diff/5002/5005 File views/controls/button/native_button_gtk.cc (right): http://codereview.chromium.org/194014/diff/5002/5005#newcode154 Line 154: } Wouldn't it be better to set deliver_click_event_ ...
11 years, 3 months ago (2009-09-03 23:31:54 UTC) #2
oshima
http://codereview.chromium.org/194014/diff/5002/5005 File views/controls/button/native_button_gtk.cc (right): http://codereview.chromium.org/194014/diff/5002/5005#newcode154 Line 154: } On 2009/09/03 23:31:54, sky wrote: > Wouldn't ...
11 years, 3 months ago (2009-09-09 02:36:02 UTC) #3
oshima
http://codereview.chromium.org/194014/diff/5002/5005 File views/controls/button/native_button_gtk.cc (right): http://codereview.chromium.org/194014/diff/5002/5005#newcode154 Line 154: } On 2009/09/09 02:36:02, oshima wrote: > On ...
11 years, 3 months ago (2009-09-10 00:47:59 UTC) #4
sky
11 years, 3 months ago (2009-09-10 15:49:13 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698