Issue 201051: Fix a build break by removing some webkit_glue stub functions from plugin_tes...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 201051: Fix a build break by removing some webkit_glue stub functions from plugin_tes... (Closed)

Created:
11 years, 3 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
amit, jam

CC:
chromium-reviews_googlegroups.com, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix a build break by removing some webkit_glue stub functions from plugin_test.cpp. These will get deleted anyway by jam's pending media player plugin changes. I also disabled the DefaultPluginParsingTest as it fails when we remove these stub functions. However this is also getting deleted in jam's media player change. TBR=amit, jam(FYI) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25648

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -21 lines)			Patch
	M	chrome/test/plugin/plugin_test.cpp	View		1 chunk	+1 line, -21 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm! thanks for looking into this issue.

Expand Messages | Collapse Messages