Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7726)

Unified Diff: chrome/test/plugin/plugin_test.cpp

Issue 201051: Fix a build break by removing some webkit_glue stub functions from plugin_tes... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/plugin/plugin_test.cpp
===================================================================
--- chrome/test/plugin/plugin_test.cpp (revision 25619)
+++ chrome/test/plugin/plugin_test.cpp (working copy)
@@ -249,27 +249,7 @@
TestActiveX(L"mpe_test.html", kLongWaitTimeout, false);
}
-
-// The default plugin tests defined below rely on the following webkit
-// functions and the IsPluginProcess function which is defined in the global
-// namespace. Stubbed these out for now.
-namespace webkit_glue {
-
-bool DownloadUrl(const std::string& url, HWND caller_window) {
- return false;
-}
-
-bool GetPluginFinderURL(std::string* plugin_finder_url) {
- return true;
-}
-
-} // namespace webkit_glue
-
-bool IsPluginProcess() {
- return false;
-}
-
-TEST_F(PluginTest, DefaultPluginParsingTest) {
+TEST_F(PluginTest, DISABLED_DefaultPluginParsingTest) {
PluginInstallerImpl plugin_installer(NP_EMBED);
NPP_t plugin_instance = {0};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698