Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 201044: Refuse to render RSS as XML by treating the response as text/plain. This is... (Closed)

Created:
11 years, 3 months ago by abarth-chromium
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam, Ben Goodger (Google)
Visibility:
Public.

Description

Refuse to render RSS as XML by treating the response as text/plain. This is somewhat unfortunate, but we need to do this until we have a built-in feed previewer. R=mal BUG=21238 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25608

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/browser/renderer_host/buffered_resource_handler.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
abarth-chromium
11 years, 3 months ago (2009-09-07 22:46:36 UTC) #1
Peter Kasting
How close to shippable is Finnur's RSS-as-page-action extension? Can we spend the effort to get ...
11 years, 3 months ago (2009-09-07 22:53:38 UTC) #2
abarth-chromium
On 2009/09/07 22:53:38, Peter Kasting wrote: > How close to shippable is Finnur's RSS-as-page-action extension? ...
11 years, 3 months ago (2009-09-07 22:57:21 UTC) #3
Mark Larson
LGTM. As Adam notes, we'll want this fix for the 3.0 branch where extensions are ...
11 years, 3 months ago (2009-09-07 23:00:29 UTC) #4
Evan Martin
I wonder how many sites get the mime-type right and how many just expect browsers ...
11 years, 3 months ago (2009-09-08 18:40:51 UTC) #5
abarth-chromium
11 years, 3 months ago (2009-09-08 18:59:04 UTC) #6
We can do the nerfing post-sniff, if you prefer, but we only sniff
feed from XML mime types.  If you're serving untrusted bytes as
application/xml, there's only so much we can do to help...

Adam


On Tuesday, September 8, 2009,  <evan@chromium.org> wrote:
> I wonder how many sites get the mime-type right and how many just expect
> browsers to sniff these complicated feed types out of a plain "XML" mime
> type.
>
> http://codereview.chromium.org/201044
>

Powered by Google App Engine
This is Rietveld 408576698