Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 20090: Add simple terminate support for now to help bring up browser/renderer, will... (Closed)

Created:
11 years, 10 months ago by TVL
Modified:
8 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add simple terminate support for now to help bring up browser/renderer, will get more work as we make it better handle the posix platform. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9238

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M base/process_posix.cc View 1 chunk +8 lines, -1 line 3 comments Download

Messages

Total messages: 4 (0 generated)
TVL
11 years, 10 months ago (2009-02-05 19:13:50 UTC) #1
Amanda Walker
lgtm
11 years, 10 months ago (2009-02-05 19:15:39 UTC) #2
Evan Stade
http://codereview.chromium.org/20090/diff/1/base/process_posix.cc File base/process_posix.cc (right): http://codereview.chromium.org/20090/diff/1/base/process_posix.cc#newcode13 base/process_posix.cc:13: // if the process wasn't termiated (so we waited) ...
8 years, 6 months ago (2012-06-23 00:04:34 UTC) #3
Evan Stade
8 years, 6 months ago (2012-06-23 00:05:17 UTC) #4
uh, please ignore. I was trying to delete old un-sent comments but hit send
instead by mistake.

Powered by Google App Engine
This is Rietveld 408576698