Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1821)

Unified Diff: base/process_posix.cc

Issue 20090: Add simple terminate support for now to help bring up browser/renderer, will... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process_posix.cc
===================================================================
--- base/process_posix.cc (revision 9229)
+++ base/process_posix.cc (working copy)
@@ -10,10 +10,17 @@
void Process::Close() {
process_ = 0;
+ // if the process wasn't termiated (so we waited) or the state
Evan Stade 2012/06/23 00:04:34 termiNated, capitalize If, don't abbreviate "with"
+ // wasn't already collected w/ a wait from process_utils, we're gonna
+ // end up w/ a zombie when it does finally exit.
}
void Process::Terminate(int result_code) {
- NOTIMPLEMENTED();
+ // result_code isn't supportable.
Evan Stade 2012/06/23 00:04:34 |result_code|
+ if (!process_)
+ return;
+ // Wait so we clean up the zombie
Evan Stade 2012/06/23 00:04:34 needs trailing period.
+ KillProcess(process_, result_code, true);
}
bool Process::IsProcessBackgrounded() const {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698