Chromium Code Reviews| Index: base/process_posix.cc |
| =================================================================== |
| --- base/process_posix.cc (revision 9229) |
| +++ base/process_posix.cc (working copy) |
| @@ -10,10 +10,17 @@ |
| void Process::Close() { |
| process_ = 0; |
| + // if the process wasn't termiated (so we waited) or the state |
|
Evan Stade
2012/06/23 00:04:34
termiNated, capitalize If, don't abbreviate "with"
|
| + // wasn't already collected w/ a wait from process_utils, we're gonna |
| + // end up w/ a zombie when it does finally exit. |
| } |
| void Process::Terminate(int result_code) { |
| - NOTIMPLEMENTED(); |
| + // result_code isn't supportable. |
|
Evan Stade
2012/06/23 00:04:34
|result_code|
|
| + if (!process_) |
| + return; |
| + // Wait so we clean up the zombie |
|
Evan Stade
2012/06/23 00:04:34
needs trailing period.
|
| + KillProcess(process_, result_code, true); |
| } |
| bool Process::IsProcessBackgrounded() const { |