Stylistic fixes in the new dock menu code:...

Stylistic fixes in the new dock menu code:
* Initialize variables when declared.
* Descriptive name (dock_menu) for the returned value.
* Use a scoped_nsobject in the unit test, not autorelease.
BUG=none
TEST=AppControllerTest.DockMenu

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26507

[pink (ping after 24hrs), 2009-09-15 12:23:33]

lgtm with changes.

http://codereview.chromium.org/200126/diff/1/2
File chrome/browser/app_controller_mac.mm (right):

http://codereview.chromium.org/200126/diff/1/2#newcode671
Line 671: NSMenu* dock_menu = [[[NSMenu alloc] initWithTitle: @""] autorelease];
in Objective C, follow the objC style guide naming, which is camel caps, ie
|dockMenu|.

http://codereview.chromium.org/200126/diff/1/2#newcode673
Line 673: NSMenuItem* item = [[[NSMenuItem alloc] initWithTitle:titleStr
this should still use scoped_nsobject.

[sgk, 2009-09-16 22:52:12]

Once more to make sure I'm using good scoped_nsobject patterns.

[pink (ping after 24hrs), 2009-09-17 16:40:39]

yup, still LGTM