Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: chrome/browser/app_controller_mac_unittest.mm

Issue 200126: Stylistic fixes in the new dock menu code:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/app_controller_mac.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/app_controller_mac_unittest.mm
===================================================================
--- chrome/browser/app_controller_mac_unittest.mm (revision 26363)
+++ chrome/browser/app_controller_mac_unittest.mm (working copy)
@@ -4,6 +4,7 @@
#import <Cocoa/Cocoa.h>
+#include "base/scoped_nsobject.h"
#include "chrome/app/chrome_dll_resource.h"
#import "chrome/browser/app_controller_mac.h"
#include "testing/platform_test.h"
@@ -12,7 +13,7 @@
};
TEST_F(AppControllerTest, DockMenu) {
- AppController* ac = [[[AppController alloc] init] autorelease];
+ scoped_nsobject<AppController> ac([[AppController alloc] init]);
NSMenu* menu = [ac applicationDockMenu:NSApp];
NSMenuItem* item;
@@ -20,7 +21,7 @@
EXPECT_NE(-1, [menu indexOfItemWithTag:IDC_NEW_WINDOW]);
EXPECT_NE(-1, [menu indexOfItemWithTag:IDC_NEW_INCOGNITO_WINDOW]);
for (item in [menu itemArray]) {
- EXPECT_EQ(ac, [item target]);
+ EXPECT_EQ(ac.get(), [item target]);
EXPECT_EQ(@selector(commandDispatch:), [item action]);
}
}
« no previous file with comments | « chrome/browser/app_controller_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698