Issue 20011: Improved OTR avatar and popup window rendering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20011: Improved OTR avatar and popup window rendering. (Closed)

Created:
11 years, 10 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
Glen Murphy

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Improved OTR avatar and popup window rendering. Neither one precisely matches the old code but IMO each looks better. Once again, the aero_glass_non_client_view changes here are hackish, and will get cleaned up later. BUG=5054 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9116

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+128 lines, -145 lines)			Patch
M	chrome/browser/autocomplete/autocomplete_popup.cc	View	2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/frame/aero_glass_frame.cc	View	1 2	2 chunks	+18 lines, -29 lines	0 comments	Download
M	chrome/browser/views/frame/aero_glass_non_client_view.cc	View	1 2 3	8 chunks	+60 lines, -74 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View	2	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/views/location_bar_view.h	View	2	2 chunks	+11 lines, -1 line	0 comments	Download
M	chrome/browser/views/location_bar_view.cc	View	2	9 chunks	+24 lines, -32 lines	0 comments	Download
M	chrome/browser/views/toolbar_view.cc	View	2	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/common/gfx/chrome_canvas.h	View	2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/gfx/chrome_canvas.cc	View	2	2 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

Updated patch to fix remainder of issues with popups, modified description accordingly.

11 years, 10 months ago (2009-02-03 21:20:54 UTC) #2

LGTM

Expand Messages | Collapse Messages