Improved OTR avatar and popup window rendering.

chrome/browser/views/frame/aero_glass_frame.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/frame/aero_glass_frame.h"
 
 #include <dwmapi.h>
 
 #include "chrome/app/theme/theme_resources.h"
 #include "chrome/browser/browser_list.h"
@@ skipping 125 matching lines @@
     frame_initialized_ = true;
   }
   browser_view_->ActivationChanged(!!active);
   SetMsgHandled(false);
   return TRUE;
 }
 
 LRESULT AeroGlassFrame::OnNCCalcSize(BOOL mode, LPARAM l_param) {
   // By default the client side is set to the window size which is what
   // we want.
-  if (browser_view_->IsToolbarVisible() && mode == TRUE) {
-    // To be on the safe side and avoid side-effects, we only adjust the client
-    // size to non-standard values when we must - i.e. when we're showing a
-    // TabStrip.
-    if (browser_view_->IsTabStripVisible()) {
-      // Calculate new NCCALCSIZE_PARAMS based on custom NCA inset.
-      NCCALCSIZE_PARAMS* params = reinterpret_cast<NCCALCSIZE_PARAMS*>(l_param);
+  if (browser_view_->IsTabStripVisible() && mode == TRUE) {
+    // Calculate new NCCALCSIZE_PARAMS based on custom NCA inset.
+    NCCALCSIZE_PARAMS* params = reinterpret_cast<NCCALCSIZE_PARAMS*>(l_param);
 
-      // Hack necessary to stop black background flicker, we cut out
-      // resizeborder here to save us from having to do too much
-      // addition and subtraction in Layout(). We don't cut off the
-      // top + titlebar as that prevents the window controls from
-      // highlighting.
-      params->rgrc[0].left +=
-          (kResizeBorder - kWindowHorizontalClientEdgeWidth);
-      params->rgrc[0].right -=
-          (kResizeBorder - kWindowHorizontalClientEdgeWidth);
-      params->rgrc[0].bottom -=
-          (kResizeBorder - kWindowBottomClientEdgeHeight);
+    // Hack necessary to stop black background flicker, we cut out
+    // resizeborder here to save us from having to do too much
+    // addition and subtraction in Layout(). We don't cut off the
+    // top + titlebar as that prevents the window controls from
+    // highlighting.
+    params->rgrc[0].left +=
+        (kResizeBorder - kWindowHorizontalClientEdgeWidth);
+    params->rgrc[0].right -=
+        (kResizeBorder - kWindowHorizontalClientEdgeWidth);
+    params->rgrc[0].bottom -=
+        (kResizeBorder - kWindowBottomClientEdgeHeight);
 
-      SetMsgHandled(TRUE);
-    } else {
-      // We don't adjust the client size for detached popups, so we need to
-      // tell Windows we didn't handle the message here so that it doesn't
-      // screw up the non-client area.
-      SetMsgHandled(FALSE);
-    }
+    SetMsgHandled(TRUE);
 
     // We need to reset the frame, as Vista resets it whenever it changes
     // composition modes (and NCCALCSIZE is the closest thing we get to
     // a reliable message about the change).
     UpdateDWMFrame();
 
     return 0;
   }
   SetMsgHandled(FALSE);
   return 0;
@@ skipping 16 matching lines @@
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // AeroGlassFrame, private:
 
 void AeroGlassFrame::UpdateDWMFrame() {
   // Nothing to do yet.
   if (!client_view())
     return;
 
-  // We only adjust the DWM's glass rendering when we're a browser window or a
-  // detached popup. App windows get the standard client edge.
-  if (browser_view_->IsTabStripVisible() ||
-      browser_view_->IsToolbarVisible()) {
+  // We only adjust the DWM's glass rendering when we're a browser window.
+  // Popups and app windows get the standard client edge.
+  if (browser_view_->IsTabStripVisible()) {
     // By default, we just want to adjust the glass by the width of the inner
     // bevel that aero renders to demarcate the client area. We supply our own
     // client edge for the browser window and detached popups, so we don't want
     // to show the default one.
     int client_edge_left_width = kWindowHorizontalClientEdgeWidth + 1;
     int client_edge_right_width = kWindowHorizontalClientEdgeWidth + 1;
     int client_edge_bottom_height = kWindowBottomClientEdgeHeight + 1;
     int client_edge_top_height = kWindowBottomClientEdgeHeight;
     if (browser_view_->IsTabStripVisible()) {
       gfx::Rect tabstrip_bounds =
@@ skipping 42 matching lines @@
   static bool initialized = false;
   if (!initialized) {
     ResourceBundle &rb = ResourceBundle::GetSharedInstance();
     for (int i = 0; i < kThrobberIconCount; ++i) {
       throbber_icons_[i] = rb.LoadThemeIcon(IDR_THROBBER_01 + i);
       DCHECK(throbber_icons_[i]);
     }
     initialized = true;
   }
 }