Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 200054: Hook up WebFrameClient, replacing many WebViewDelegate methods.... (Closed)

Created:
11 years, 3 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
dglazkov
CC:
chromium-reviews_googlegroups.com, fbarchard, Alpha Left Google, jam, pam+watch_chromium.org, awong, Paweł Hajdan Jr., darin (slow to review), brettw, scherkus (not reviewing)
Visibility:
Public.

Description

Hook up WebFrameClient, replacing many WebViewDelegate methods. Moved NavigationGesture out of webview_delegate.h into its own header in chrome/common since it is only needed by Chrome. Adds WebFrame::isProcessingUserGesture to facilitate the removal of NavigationGesture. Cleaned up some TestShell methods related to URL loading. The method to load an URL now takes a GURL instead of a wchar_t*. R=dglazkov BUG=21332 TEST=none

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Patch Set 10 : '' #

Patch Set 11 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1499 lines, -2562 lines) Patch
M chrome/chrome.gyp View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/common/navigation_gesture.h View 2 chunks +3 lines, -740 lines 0 comments Download
M chrome/common/render_messages.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/print_web_view_helper.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_view.h View 1 2 3 4 5 6 7 9 chunks +75 lines, -73 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 2 3 4 5 6 7 14 chunks +595 lines, -583 lines 0 comments Download
M chrome/renderer/render_view_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -2 lines 0 comments Download
M webkit/api/public/WebFrame.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/api/public/WebFrameClient.h View 1 2 3 4 5 6 7 7 chunks +38 lines, -11 lines 0 comments Download
M webkit/glue/bookmarklet_unittest.cc View 1 2 3 4 5 6 7 3 chunks +10 lines, -8 lines 0 comments Download
M webkit/glue/chrome_client_impl.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -4 lines 0 comments Download
M webkit/glue/chromium_bridge_impl.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/glue/context_menu_unittest.cc View 1 2 3 4 5 6 7 1 chunk +3 lines, -4 lines 0 comments Download
M webkit/glue/cpp_bound_class_unittest.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/glue/dom_operations_unittest.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -4 lines 0 comments Download
M webkit/glue/dom_serializer_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/editor_client_impl.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
A webkit/glue/empty_webframeclient.h View 1 chunk +89 lines, -0 lines 0 comments Download
M webkit/glue/iframe_redirect_unittest.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/inspector_client_impl.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/glue/mimetype_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/temporary_glue.cc View 1 2 3 4 5 6 7 2 chunks +6 lines, -4 lines 0 comments Download
M webkit/glue/webframe_impl.h View 1 2 3 4 5 6 7 5 chunks +8 lines, -1 line 0 comments Download
M webkit/glue/webframe_impl.cc View 1 2 3 4 5 6 7 8 chunks +19 lines, -14 lines 0 comments Download
M webkit/glue/webframeloaderclient_impl.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/glue/webframeloaderclient_impl.cc View 1 2 3 4 5 6 7 27 chunks +94 lines, -141 lines 0 comments Download
M webkit/glue/webview.h View 1 2 3 4 5 6 7 2 chunks +5 lines, -3 lines 0 comments Download
M webkit/glue/webview_delegate.h View 1 2 3 4 5 6 7 7 chunks +1 line, -346 lines 0 comments Download
M webkit/glue/webview_impl.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webview_impl.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/glue/webworker_impl.cc View 1 2 3 4 5 6 7 5 chunks +14 lines, -26 lines 0 comments Download
M webkit/glue/webworkerclient_impl.cc View 1 2 3 4 5 6 7 3 chunks +4 lines, -8 lines 0 comments Download
M webkit/tools/test_shell/layout_test_controller.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -2 lines 0 comments Download
M webkit/tools/test_shell/listener_leak_test.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/mac/test_shell_webview.mm View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/mac/webview_host.mm View 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/media_leak_test.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/node_leak_test.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/plugin_tests.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell.h View 1 2 3 4 5 6 7 8 3 chunks +6 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 1 2 3 4 5 6 7 8 5 chunks +15 lines, -6 lines 0 comments Download
M webkit/tools/test_shell/test_shell_gtk.cc View 3 4 5 6 7 8 6 chunks +14 lines, -31 lines 0 comments Download
M webkit/tools/test_shell/test_shell_mac.mm View 9 5 chunks +11 lines, -28 lines 0 comments Download
M webkit/tools/test_shell/test_shell_main.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_test.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell_test.cc View 1 2 3 4 5 6 7 3 chunks +6 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/test_shell_win.cc View 1 2 3 4 5 6 7 8 6 chunks +19 lines, -35 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 1 2 3 4 5 6 7 5 chunks +64 lines, -102 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 2 3 4 5 6 7 5 chunks +350 lines, -339 lines 0 comments Download
M webkit/tools/test_shell/webview_host_gtk.cc View 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/webview_host_win.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M webkit/webkit.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
darin (slow to review)
11 years, 3 months ago (2009-09-09 18:06:11 UTC) #1
dglazkov
11 years, 3 months ago (2009-09-09 18:30:52 UTC) #2 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698