Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: webkit/glue/editor_client_impl.cc

Issue 200054: Hook up WebFrameClient, replacing many WebViewDelegate methods.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/dom_serializer_unittest.cc ('k') | webkit/glue/empty_webframeclient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/editor_client_impl.cc
===================================================================
--- webkit/glue/editor_client_impl.cc (revision 25715)
+++ webkit/glue/editor_client_impl.cc (working copy)
@@ -658,6 +658,9 @@
// Hide any showing popup.
web_view_->HideAutoCompletePopup();
+ if (!editing_client_)
+ return; // The page is getting closed, don't fill the password.
+
// Notify any password-listener of the focus change.
WebCore::HTMLInputElement* input_element =
webkit_glue::ElementToHTMLInputElement(element);
@@ -666,9 +669,6 @@
WebFrameImpl* webframe =
WebFrameImpl::FromFrame(input_element->document()->frame());
- if (webframe->GetWebViewImpl() && !webframe->GetWebViewImpl()->GetDelegate())
- return; // The page is getting closed, don't fill the password.
-
webkit_glue::PasswordAutocompleteListener* listener =
webframe->GetPasswordListener(input_element);
if (!listener)
« no previous file with comments | « webkit/glue/dom_serializer_unittest.cc ('k') | webkit/glue/empty_webframeclient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698