Issue 200036: The prep_libc script was not removing the new operator for the std::throw cas...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200036: The prep_libc script was not removing the new operator for the std::throw cas... (Closed)

Created:
11 years, 3 months ago by Mike Belshe

Modified:
9 years, 5 months ago

Reviewers:
antonm

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

The prep_libc script was not removing the new operator for the std::throw case. This funciton is defined as part of tcmalloc; it shouldn't be in libcmt anymore. BUG=none TEST=none; we're removing code from libc. If this is a problem, it will fail to link. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25601

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	third_party/tcmalloc/prep_libc.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mike Belshe

This becomes a problem once we link tcmalloc into some of the test libraries that ...

11 years, 3 months ago (2009-09-07 17:05:38 UTC) #1

Anton Muhin

11 years, 3 months ago (2009-09-07 17:16:15 UTC) #2

lgtm and thanks.

yours,
anton.

On Mon, Sep 7, 2009 at 9:05 PM, <mbelshe@chromium.org> wrote:
> Reviewers: antonm,
>
> Message:
> This becomes a problem once we link tcmalloc into some of the test
> libraries that use the std::nothrow version of new.
>
> Description:
> The prep_libc script was not removing the new operator for the
> std::throw case.
> This funciton is defined as part of tcmalloc; it shouldn't be in libcmt
> anymore.
>
> BUG=3Dnone
> TEST=3Dnone; we're removing code from libc. =A0If this is a problem, it w=
ill
> fail to link.
>
> Please review this at http://codereview.chromium.org/200036
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 third_party/tcmalloc/prep_libc.sh
>
>
> Index: third_party/tcmalloc/prep_libc.sh
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- third_party/tcmalloc/prep_libc.sh =A0 (revision 25582)
> +++ third_party/tcmalloc/prep_libc.sh =A0 (working copy)
> @@ -25,7 +25,7 @@
> =A0LIBCMTSRCPATHVS2005=3D"build\\intel\\mt_obj\\"
> =A0LIBCMTSRCPATHVS2008=3D"f:\\dd\\vctools\\crt_bld\\SELF_X86\\crt\\src\\b=
uild\\INTEL\\mt_obj\\"
>
> -OBJFILES=3D"malloc.obj free.obj realloc.obj new.obj delete.obj new2.obj
> delete2.obj align.obj msize.obj heapinit.obj expand.obj heapchk.obj
> heapwalk.obj heapmin.obj sbheap.obj calloc.obj recalloc.obj calloc_impl.o=
bj
> new_mode.obj"
> +OBJFILES=3D"malloc.obj free.obj realloc.obj new.obj delete.obj new2.obj
> delete2.obj align.obj msize.obj heapinit.obj expand.obj heapchk.obj
> heapwalk.obj heapmin.obj sbheap.obj calloc.obj recalloc.obj calloc_impl.o=
bj
> new_mode.obj newopnt.obj"
>
> =A0for FILE in $OBJFILES
> =A0do
>
>
>

Expand Messages | Collapse Messages