Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: views/controls/textfield/native_textfield_gtk.cc

Issue 200035: First cut at implementation of FindBar for views / gtk... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: views/controls/textfield/native_textfield_gtk.cc
===================================================================
--- views/controls/textfield/native_textfield_gtk.cc (revision 25765)
+++ views/controls/textfield/native_textfield_gtk.cc (working copy)
@@ -134,18 +134,48 @@
return native_view();
}
+// static
+gboolean NativeTextfieldGtk::OnKeyPressEventHandler(
+ GtkWidget* entry,
+ GdkEventKey* event,
+ NativeTextfieldGtk* textfield) {
+ return textfield->OnKeyPressEvent(event);
+}
+
+gboolean NativeTextfieldGtk::OnKeyPressEvent(GdkEventKey* event) {
+ Textfield::Controller* controller = textfield_->GetController();
+ if (controller)
+ return controller->HandleKeystroke(textfield_, Textfield::Keystroke(event));
+ return false;
+}
+
+// static
+gboolean NativeTextfieldGtk::OnChangedHandler(
+ GtkWidget* entry,
+ NativeTextfieldGtk* textfield) {
+ return textfield->OnChanged();
+}
+
+gboolean NativeTextfieldGtk::OnChanged() {
+ Textfield::Controller* controller = textfield_->GetController();
+ if (controller)
+ controller->ContentsChanged(textfield_, GetText());
+ return false;
+}
+
////////////////////////////////////////////////////////////////////////////////
// NativeTextfieldGtk, NativeControlGtk overrides:
void NativeTextfieldGtk::CreateNativeControl() {
- // TODO(brettw) hook in an observer to get text change events so we can call
- // the controller.
NativeControlCreated(gtk_entry_new());
}
void NativeTextfieldGtk::NativeControlCreated(GtkWidget* widget) {
NativeControlGtk::NativeControlCreated(widget);
- // TODO(port): post-creation init
+ g_signal_connect(widget, "changed",
+ G_CALLBACK(OnChangedHandler), this);
+ g_signal_connect(widget, "key-press-event",
+ G_CALLBACK(OnKeyPressEventHandler), this);
}
////////////////////////////////////////////////////////////////////////////////

Powered by Google App Engine
This is Rietveld 408576698