Issue 200033: Update the Strict-Transport-Security grammar to match the spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 200033: Update the Strict-Transport-Security grammar to match the spec. (Closed)

Created:
11 years, 3 months ago by abarth-chromium

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, willchan no longer on Chromium, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Update the Strict-Transport-Security grammar to match the spec. R=agl Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25634

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -14 lines)			Patch
	M	net/base/strict_transport_security_state.cc	View	1	7 chunks	+13 lines, -11 lines	1 comment	Download
	M	net/base/strict_transport_security_state_unittest.cc	View		2 chunks	+15 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

agl

11 years, 3 months ago (2009-09-08 17:11:41 UTC) #2

LGTM

http://codereview.chromium.org/200033/diff/1002/8
File net/base/strict_transport_security_state.cc (right):

http://codereview.chromium.org/200033/diff/1002/8#newcode87
Line 87: StringTokenizer tokenizer(value, " \t=;");
:( HTTP is such a terrible protocol

Expand Messages | Collapse Messages