Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: net/base/strict_transport_security_state_unittest.cc

Issue 200033: Update the Strict-Transport-Security grammar to match the spec. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/strict_transport_security_state_unittest.cc
===================================================================
--- net/base/strict_transport_security_state_unittest.cc (revision 25577)
+++ net/base/strict_transport_security_state_unittest.cc (working copy)
@@ -78,6 +78,8 @@
"max-age=3488923 includesubdomains x", &max_age, &include_subdomains));
EXPECT_FALSE(net::StrictTransportSecurityState::ParseHeader(
"max-age=34889.23 includesubdomains", &max_age, &include_subdomains));
+ EXPECT_FALSE(net::StrictTransportSecurityState::ParseHeader(
+ "max-age=34889 includesubdomains", &max_age, &include_subdomains));
EXPECT_EQ(max_age, 42);
EXPECT_FALSE(include_subdomains);
@@ -103,17 +105,27 @@
EXPECT_FALSE(include_subdomains);
EXPECT_TRUE(net::StrictTransportSecurityState::ParseHeader(
- "max-age=123 incLudesUbdOmains", &max_age, &include_subdomains));
+ "max-age=123;incLudesUbdOmains", &max_age, &include_subdomains));
EXPECT_EQ(max_age, 123);
EXPECT_TRUE(include_subdomains);
EXPECT_TRUE(net::StrictTransportSecurityState::ParseHeader(
- "max-age=394082038 incLudesUbdOmains", &max_age, &include_subdomains));
+ "max-age=394082; incLudesUbdOmains", &max_age, &include_subdomains));
+ EXPECT_EQ(max_age, 394082);
+ EXPECT_TRUE(include_subdomains);
+
+ EXPECT_TRUE(net::StrictTransportSecurityState::ParseHeader(
+ "max-age=39408299 ;incLudesUbdOmains", &max_age, &include_subdomains));
+ EXPECT_EQ(max_age, 39408299);
+ EXPECT_TRUE(include_subdomains);
+
+ EXPECT_TRUE(net::StrictTransportSecurityState::ParseHeader(
+ "max-age=394082038 ; incLudesUbdOmains", &max_age, &include_subdomains));
EXPECT_EQ(max_age, 394082038);
EXPECT_TRUE(include_subdomains);
EXPECT_TRUE(net::StrictTransportSecurityState::ParseHeader(
- " max-age=0 incLudesUbdOmains ", &max_age, &include_subdomains));
+ " max-age=0 ; incLudesUbdOmains ", &max_age, &include_subdomains));
EXPECT_EQ(max_age, 0);
EXPECT_TRUE(include_subdomains);
}
« net/base/strict_transport_security_state.cc ('K') | « net/base/strict_transport_security_state.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698