Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 200031: Take out the activex control. (Closed)

Created:
11 years, 3 months ago by jam
Modified:
9 years, 6 months ago
Reviewers:
Peter Kasting, ananta
CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, Paweł Hajdan Jr., darin (slow to review), brettw, Ben Goodger (Google)
Visibility:
Public.

Description

Take out the activex control.BUG=20259 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25650

Patch Set 1 : '' #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -6477 lines) Patch
M build/all.gyp View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_plugin_host.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_process_host.h View 1 2 3 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/plugin_process_host.cc View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/plugin_service.h View 1 2 3 3 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/plugin_service.cc View 1 2 3 3 chunks +13 lines, -16 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/buffered_resource_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/sandbox_policy.cc View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 2 chunks +0 lines, -29 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 2 chunks +1 line, -7 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/renderer/render_view.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/render_view.cc View 1 2 3 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.h View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 1 2 3 2 chunks +1 line, -3 lines 0 comments Download
D chrome/test/activex_test_control/activex_test_control.cc View 1 2 3 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/test/activex_test_control/activex_test_control.def View 1 2 3 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/test/activex_test_control/activex_test_control.idl View 1 2 3 1 chunk +0 lines, -108 lines 0 comments Download
D chrome/test/activex_test_control/activex_test_control.rc View 1 2 3 1 chunk +0 lines, -128 lines 0 comments Download
D chrome/test/activex_test_control/activex_test_control.rgs View 1 2 3 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/test/activex_test_control/chrome_test_control.h View 1 2 3 1 chunk +0 lines, -263 lines 0 comments Download
D chrome/test/activex_test_control/chrome_test_control.bmp View Binary file 0 comments Download
D chrome/test/activex_test_control/chrome_test_control.cc View 1 2 3 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/test/activex_test_control/chrome_test_control.rgs View 1 2 3 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/test/activex_test_control/chrome_test_control_cp.h View 1 2 3 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/test/activex_test_control/resource.h View 1 2 3 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/test/plugin/plugin_test.cpp View 1 2 3 2 chunks +0 lines, -151 lines 0 comments Download
D webkit/activex_shim/README View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
D webkit/activex_shim/activex_plugin.h View 1 2 3 1 chunk +0 lines, -103 lines 0 comments Download
D webkit/activex_shim/activex_plugin.cc View 1 2 3 1 chunk +0 lines, -485 lines 0 comments Download
D webkit/activex_shim/activex_shared.h View 1 2 3 1 chunk +0 lines, -70 lines 0 comments Download
D webkit/activex_shim/activex_shared.cc View 1 2 3 1 chunk +0 lines, -241 lines 0 comments Download
D webkit/activex_shim/activex_shim.gyp View 1 2 3 1 chunk +0 lines, -54 lines 0 comments Download
D webkit/activex_shim/activex_util.h View 1 2 3 1 chunk +0 lines, -167 lines 0 comments Download
D webkit/activex_shim/activex_util.cc View 1 2 3 1 chunk +0 lines, -476 lines 0 comments Download
D webkit/activex_shim/dispatch_object.h View 1 2 3 1 chunk +0 lines, -123 lines 0 comments Download
D webkit/activex_shim/dispatch_object.cc View 1 2 3 1 chunk +0 lines, -290 lines 0 comments Download
D webkit/activex_shim/ihtmldocument_impl.h View 1 2 3 1 chunk +0 lines, -483 lines 0 comments Download
D webkit/activex_shim/iwebbrowser_impl.h View 1 2 3 1 chunk +0 lines, -303 lines 0 comments Download
D webkit/activex_shim/npn_scripting.h View 1 2 3 1 chunk +0 lines, -95 lines 0 comments Download
D webkit/activex_shim/npn_scripting.cc View 1 2 3 1 chunk +0 lines, -270 lines 0 comments Download
D webkit/activex_shim/npp_impl.h View 1 2 3 1 chunk +0 lines, -23 lines 0 comments Download
D webkit/activex_shim/npp_impl.cc View 1 2 3 1 chunk +0 lines, -148 lines 0 comments Download
D webkit/activex_shim/web_activex_container.h View 1 2 3 1 chunk +0 lines, -191 lines 0 comments Download
D webkit/activex_shim/web_activex_container.cc View 1 2 3 1 chunk +0 lines, -351 lines 0 comments Download
D webkit/activex_shim/web_activex_site.h View 1 2 3 1 chunk +0 lines, -225 lines 0 comments Download
D webkit/activex_shim/web_activex_site.cc View 1 2 3 1 chunk +0 lines, -672 lines 0 comments Download
D webkit/activex_shim_dll/activex_shim_dll.cc View 1 2 3 1 chunk +0 lines, -46 lines 0 comments Download
D webkit/activex_shim_dll/activex_shim_dll.def View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
D webkit/activex_shim_dll/activex_shim_dll.gyp View 1 2 3 1 chunk +0 lines, -45 lines 0 comments Download
D webkit/activex_shim_dll/activex_shim_dll.rc View 1 2 3 1 chunk +0 lines, -91 lines 0 comments Download
D webkit/activex_shim_dll/resource.h View 1 2 3 1 chunk +0 lines, -15 lines 0 comments Download
D webkit/default_plugin/activex_installer.h View 1 2 3 1 chunk +0 lines, -66 lines 0 comments Download
D webkit/default_plugin/activex_installer.cc View 1 2 3 1 chunk +0 lines, -117 lines 0 comments Download
M webkit/default_plugin/default_plugin.gyp View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
M webkit/default_plugin/default_plugin_shared.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/default_plugin/plugin_impl_win.h View 1 2 3 9 chunks +1 line, -64 lines 0 comments Download
M webkit/default_plugin/plugin_impl_win.cc View 1 2 3 10 chunks +19 lines, -159 lines 0 comments Download
M webkit/default_plugin/plugin_main.cc View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M webkit/glue/plugins/plugin_constants_win.h View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
M webkit/glue/plugins/plugin_list.h View 1 2 3 3 chunks +6 lines, -16 lines 0 comments Download
webkit/glue/plugins/plugin_list.cc View 1 2 3 6 chunks +5 lines, -27 lines 0 comments Download
M webkit/glue/plugins/plugin_list_linux.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/glue/plugins/plugin_list_mac.mm View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/glue/plugins/plugin_list_win.cc View 1 2 3 3 chunks +12 lines, -51 lines 0 comments Download
M webkit/glue/webplugin_impl.cc View 1 2 3 3 chunks +2 lines, -34 lines 0 comments Download
webkit/glue/webplugin_page_delegate.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/mac/test_webview_delegate.mm View 2 3 2 chunks +3 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_gtk.cc View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_win.cc View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download
M webkit/webkit.gyp View 1 2 3 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
11 years, 3 months ago (2009-09-05 01:45:09 UTC) #1
ananta
LGTM Good luck with the reliability test runs :)
11 years, 3 months ago (2009-09-05 02:07:13 UTC) #2
ananta
LGTM
11 years, 3 months ago (2009-09-05 02:08:35 UTC) #3
Peter Kasting
Shouldn't webkit.gyp remove the "DISABLE_ACTIVEX_TYPE_CONVERSION_MPLAYER2"? And perhaps upstream in WebKit remove the functionality related to ...
11 years, 3 months ago (2009-09-05 18:23:24 UTC) #4
jam
11 years, 3 months ago (2009-09-08 17:04:21 UTC) #5 
Yes, thanks for bringing this up.  I'll update this patch and send a patch
upstream.

On Sat, Sep 5, 2009 at 11:23 AM, <pkasting@chromium.org> wrote:

> Shouldn't webkit.gyp remove the
> "DISABLE_ACTIVEX_TYPE_CONVERSION_MPLAYER2"?  And perhaps upstream in
> WebKit remove the functionality related to that, since no one will be
> using it anymore?
>
>
> http://codereview.chromium.org/200031
>

Powered by Google App Engine
This is Rietveld 408576698