Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 200013: Linux Breakpad: Use MD_MODULE_SIZE in place of sizeof(MDRawModule).... (Closed)

Created:
11 years, 3 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
nealsid, agl
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux Breakpad: Use MD_MODULE_SIZE in place of sizeof(MDRawModule). BUG=none TEST=minidump_dump can read the generated .dmp files. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M breakpad/linux/minidump-2-core.cc View 1 chunk +1 line, -1 line 0 comments Download
M breakpad/linux/minidump_writer.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
11 years, 3 months ago (2009-09-04 00:33:21 UTC) #1
agl
LGTM
11 years, 3 months ago (2009-09-04 01:17:00 UTC) #2
nealsid
11 years, 3 months ago (2009-09-04 17:04:19 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698