Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2427)

Unified Diff: breakpad/linux/minidump_writer.cc

Issue 200013: Linux Breakpad: Use MD_MODULE_SIZE in place of sizeof(MDRawModule).... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « breakpad/linux/minidump-2-core.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: breakpad/linux/minidump_writer.cc
===================================================================
--- breakpad/linux/minidump_writer.cc (revision 25382)
+++ breakpad/linux/minidump_writer.cc (working copy)
@@ -500,7 +500,7 @@
}
TypedMDRVA<uint32_t> list(&minidump_writer_);
- if (!list.AllocateObjectAndArray(num_output_mappings, sizeof(MDRawModule)))
+ if (!list.AllocateObjectAndArray(num_output_mappings, MD_MODULE_SIZE))
return false;
dirent->stream_type = MD_MODULE_LIST_STREAM;
@@ -513,7 +513,7 @@
continue;
MDRawModule mod;
- my_memset(&mod, 0, sizeof(mod));
+ my_memset(&mod, 0, MD_MODULE_SIZE);
mod.base_of_image = mapping.start_addr;
mod.size_of_image = mapping.size;
const size_t filepath_len = my_strlen(mapping.name);
@@ -569,7 +569,7 @@
return false;
mod.module_name_rva = ld.rva;
- list.CopyIndexAfterObject(j++, &mod, sizeof(mod));
+ list.CopyIndexAfterObject(j++, &mod, MD_MODULE_SIZE);
}
return true;
« no previous file with comments | « breakpad/linux/minidump-2-core.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698