Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: src/client/windows/crash_generation/minidump_generator.cc

Issue 1994015: Moved exception_handler_test to the more aptly named exception_handler_death_... (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/
Patch Set: '' Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/client/windows/crash_generation/minidump_generator.cc
===================================================================
--- src/client/windows/crash_generation/minidump_generator.cc (revision 592)
+++ src/client/windows/crash_generation/minidump_generator.cc (working copy)
@@ -68,6 +68,23 @@
MINIDUMP_TYPE dump_type,
bool is_client_pointers,
wstring* dump_path) {
+ // Just call the full WriteMinidump with NULL as the full_dump_path.
+ return this->WriteMinidump(process_handle, process_id, thread_id,
+ requesting_thread_id, exception_pointers,
+ assert_info, dump_type, is_client_pointers,
+ dump_path, NULL);
+}
+
+bool MinidumpGenerator::WriteMinidump(HANDLE process_handle,
+ DWORD process_id,
+ DWORD thread_id,
+ DWORD requesting_thread_id,
+ EXCEPTION_POINTERS* exception_pointers,
+ MDRawAssertionInfo* assert_info,
+ MINIDUMP_TYPE dump_type,
+ bool is_client_pointers,
+ wstring* dump_path,
+ wstring* full_dump_path) {
MiniDumpWriteDumpType write_dump = GetWriteDump();
if (!write_dump) {
return false;
@@ -223,6 +240,9 @@
if (result && dump_path) {
*dump_path = dump_file_path;
}
+ if (result && full_memory_dump && full_dump_path) {
+ *full_dump_path = full_dump_file_path;
+ }
return result;
}
@@ -275,7 +295,7 @@
UUID id = {0};
UuidCreateType create_uuid = GetCreateUuid();
- if(!create_uuid) {
+ if (!create_uuid) {
return false;
}
« no previous file with comments | « src/client/windows/crash_generation/minidump_generator.h ('k') | src/client/windows/handler/exception_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698