Moved exception_handler_test to the more aptly named exception_handler_death_...

src/client/windows/crash_generation/minidump_generator.cc

 // Copyright (c) 2008, Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
@@ skipping 50 matching lines @@
 
 bool MinidumpGenerator::WriteMinidump(HANDLE process_handle,
                                       DWORD process_id,
                                       DWORD thread_id,
                                       DWORD requesting_thread_id,
                                       EXCEPTION_POINTERS* exception_pointers,
                                       MDRawAssertionInfo* assert_info,
                                       MINIDUMP_TYPE dump_type,
                                       bool is_client_pointers,
                                       wstring* dump_path) {
+  // Just call the full WriteMinidump with NULL as the full_dump_path.
+  return this->WriteMinidump(process_handle, process_id, thread_id,
+                             requesting_thread_id, exception_pointers,
+                             assert_info, dump_type, is_client_pointers,
+                             dump_path, NULL);
+}
+
+bool MinidumpGenerator::WriteMinidump(HANDLE process_handle,
+                                      DWORD process_id,
+                                      DWORD thread_id,
+                                      DWORD requesting_thread_id,
+                                      EXCEPTION_POINTERS* exception_pointers,
+                                      MDRawAssertionInfo* assert_info,
+                                      MINIDUMP_TYPE dump_type,
+                                      bool is_client_pointers,
+                                      wstring* dump_path,
+                                      wstring* full_dump_path) {
   MiniDumpWriteDumpType write_dump = GetWriteDump();
   if (!write_dump) {
     return false;
   }
 
   wstring dump_file_path;
   if (!GenerateDumpFilePath(&dump_file_path)) {
     return false;
   }
 
@@ skipping 135 matching lines @@
 
   CloseHandle(dump_file);
   if (full_dump_file != INVALID_HANDLE_VALUE)
     CloseHandle(full_dump_file);
 
   // Store the path of the dump file in the out parameter if dump generation
   // succeeded.
   if (result && dump_path) {
     *dump_path = dump_file_path;
   }
+  if (result && full_memory_dump && full_dump_path) {
+    *full_dump_path = full_dump_file_path;
+  }
 
   return result;
 }
 
 HMODULE MinidumpGenerator::GetDbghelpModule() {
   AutoCriticalSection lock(&module_load_sync_);
   if (!dbghelp_module_) {
     dbghelp_module_ = LoadLibrary(TEXT("dbghelp.dll"));
   }
 
@@ skipping 32 matching lines @@
     }
   }
 
   return create_uuid_;
 }
 
 bool MinidumpGenerator::GenerateDumpFilePath(wstring* file_path) {
   UUID id = {0};
 
   UuidCreateType create_uuid = GetCreateUuid();
-  if(!create_uuid) {
+  if (!create_uuid) {
     return false;
   }
 
   create_uuid(&id);
   wstring id_str = GUIDString::GUIDToWString(&id);
 
   *file_path = dump_path_ + TEXT("\\") + id_str + TEXT(".dmp");
   return true;
 }
 
 }  // namespace google_breakpad