Issue 199055: DevTools: add setting/setSetting methods to InspectorController in front-end

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 199055: DevTools: add setting/setSetting methods to InspectorController in front-end (Closed)

Created:
11 years, 3 months ago by yurys

Modified:
9 years, 7 months ago

Reviewers:
mnaganov (inactive), pfeldman

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DevTools: add setting/setSetting methods to InspectorController in front-end. Nuke some methods that now live in WebKit. BUG=21277

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -34 lines)			Patch
	M	webkit/glue/devtools/js/inspector_controller_impl.js	View	1	2 chunks	+4 lines, -34 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pfeldman

11 years, 1 month ago (2009-11-18 16:58:19 UTC) #3

http://codereview.chromium.org/199055/diff/1001/2001
File webkit/glue/devtools/js/inspector_controller_impl.js (right):

http://codereview.chromium.org/199055/diff/1001/2001#newcode28
Line 28: this.installInspectorControllerDelegate_('setting');
Hm... How is setting supposed to return the value over the process boundary?

Expand Messages | Collapse Messages