DevTools: add setting/setSetting methods to InspectorController in front-end

webkit/glue/devtools/js/inspector_controller_impl.js

Index: webkit/glue/devtools/js/inspector_controller_impl.js
===================================================================
--- webkit/glue/devtools/js/inspector_controller_impl.js	(revision 25714)
+++ webkit/glue/devtools/js/inspector_controller_impl.js	(working copy)
@@ -25,25 +25,8 @@
   this.installInspectorControllerDelegate_('disableResourceTracking');
   this.installInspectorControllerDelegate_('enableTimeline');
   this.installInspectorControllerDelegate_('disableTimeline');
-
-  //TODO: nuke with the next WebKit roll.
-  this.installInjectedScriptDelegate_('getStyles');
-  this.installInjectedScriptDelegate_('getComputedStyle');
-  this.installInjectedScriptDelegate_('getInlineStyle');
-  this.installInjectedScriptDelegate_('applyStyleText');
-  this.installInjectedScriptDelegate_('setStyleText');
-  this.installInjectedScriptDelegate_('toggleStyleEnabled');
-  this.installInjectedScriptDelegate_('applyStyleRuleText');
-  this.installInjectedScriptDelegate_('addStyleSelector');
-  this.installInjectedScriptDelegate_('setStyleProperty');
-  this.installInjectedScriptDelegate_('getPrototypes');
-  this.installInjectedScriptDelegate_('setPropertyValue');
-  this.installInjectedScriptDelegate_('evaluate');
-  this.installInjectedScriptDelegate_('addInspectedNode');
-  this.installInjectedScriptDelegate_('pushNodeToFrontend');
-  this.installInjectedScriptDelegate_('performSearch');
-  this.installInjectedScriptDelegate_('searchCanceled');
-  this.installInjectedScriptDelegate_('openInInspectedWindow');
+  this.installInspectorControllerDelegate_('setting');

[pfeldman, 2009/11/18 16:58:19]

Hm... How is setting supposed to return the value over the process boundary?

+  this.installInspectorControllerDelegate_('setSetting');
 };
 goog.inherits(devtools.InspectorControllerImpl,
     devtools.InspectorController);
@@ -287,22 +270,9 @@
 
 
 /**
- * TODO: nuke with the next WebKit roll.
- * Installs delegating handler into the inspector controller.
- * @param {string} methodName Method to install delegating handler for.
+ * This method allows calling a methods on InjectedScript object in the
+ * inspected page.
  */
-devtools.InspectorControllerImpl.prototype.installInjectedScriptDelegate_ =
-    function(methodName) {
-  this[methodName] = goog.bind(this.callInjectedScript_, this,
-      methodName);
-};
-
-
-/**
- * TODO: nuke with the next WebKit roll.
- * Bound function with the installInjectedScriptDelegate_ actual
- * implementation.
- */
 devtools.InspectorControllerImpl.prototype.callInjectedScript_ =
     function(methodName, var_arg) {
   var allArgs = Array.prototype.slice.call(arguments);