Add methods for setting socket buffers to the Socket

Add methods for setting socket buffers to the Socket 
class.

Also add a few stats counters for TCP read/write stats.
BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25803

[willchan no longer on Chromium, 2009-09-09 19:49:50]

LGTM mod the nits.

http://codereview.chromium.org/199048/diff/6001/7010
File net/socket/client_socket_pool_base_unittest.cc (right):

http://codereview.chromium.org/199048/diff/6001/7010#newcode45
Line 45: virtual bool SetReceiveBufferSize(int32 size) { return true; };
Doesn't matter much, but for these mocks, it might be better to add in a
NOTIMPLEMENTED().  Might be too much of a pain though.  Up to you.

http://codereview.chromium.org/199048/diff/6001/7013
File net/socket/tcp_client_socket_libevent.cc (right):

http://codereview.chromium.org/199048/diff/6001/7013#newcode269
Line 269: DCHECK(!rv) << "Could not set socket receive buffer size";
You should also print out errno.

http://codereview.chromium.org/199048/diff/6001/7013#newcode277
Line 277: DCHECK(!rv) << "Could not set socket send buffer size";
ditto

http://codereview.chromium.org/199048/diff/6001/7001
File net/socket/tcp_client_socket_win.cc (right):

http://codereview.chromium.org/199048/diff/6001/7001#newcode244
Line 244: static StatsCounter connects("tcp.connect");
You're adding these StatsCounter things too.  You should update your changelist
description.

http://codereview.chromium.org/199048/diff/6001/7001#newcode452
Line 452: int rv = setsockopt(socket_, SOL_SOCKET, SO_RCVBUF,
Your formatting is off here.  From the style guide
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Function_Calls):
"If the arguments do not all fit on one line, they should be broken up onto
multiple lines, with each subsequent line aligned with the first argument. Do
not add spaces after the open paren or before the close paren:"

Same for your other setsockopt() calls.

http://codereview.chromium.org/199048/diff/6001/7001#newcode455
Line 455: DCHECK(!rv) << "Could not set socket receive buffer size";
You should probably also print out the errno (or whatever it is in windows,
WSAGetLastError() or something).

http://codereview.chromium.org/199048/diff/6001/7001#newcode463
Line 463: DCHECK(!rv) << "Could not set socket send buffer size";
Ditto here.

http://codereview.chromium.org/199048/diff/6001/7002
File net/socket/tcp_client_socket_win.h (right):

http://codereview.chromium.org/199048/diff/6001/7002#newcode39
Line 39: virtual bool SetSendBufferSize(int32 size);
You should have a newline before the "private:" section.

[Mike Belshe, 2009-09-09 22:18:56]

http://codereview.chromium.org/199048/diff/6001/7013
File net/socket/tcp_client_socket_libevent.cc (right):

http://codereview.chromium.org/199048/diff/6001/7013#newcode269
Line 269: DCHECK(!rv) << "Could not set socket receive buffer size";
On 2009/09/09 19:49:50, willchan wrote:
> You should also print out errno.

Done.

http://codereview.chromium.org/199048/diff/6001/7013#newcode277
Line 277: DCHECK(!rv) << "Could not set socket send buffer size";
On 2009/09/09 19:49:50, willchan wrote:
> ditto

Done.

http://codereview.chromium.org/199048/diff/6001/7001
File net/socket/tcp_client_socket_win.cc (right):

http://codereview.chromium.org/199048/diff/6001/7001#newcode244
Line 244: static StatsCounter connects("tcp.connect");
On 2009/09/09 19:49:50, willchan wrote:
> You're adding these StatsCounter things too.  You should update your
changelist
> description.

Done.

http://codereview.chromium.org/199048/diff/6001/7001#newcode452
Line 452: int rv = setsockopt(socket_, SOL_SOCKET, SO_RCVBUF,
On 2009/09/09 19:49:50, willchan wrote:
> Your formatting is off here.  From the style guide
>
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Function_Calls%29:
> "If the arguments do not all fit on one line, they should be broken up onto
> multiple lines, with each subsequent line aligned with the first argument. Do
> not add spaces after the open paren or before the close paren:"
> 
> Same for your other setsockopt() calls.

Done.

http://codereview.chromium.org/199048/diff/6001/7001#newcode455
Line 455: DCHECK(!rv) << "Could not set socket receive buffer size";
On 2009/09/09 19:49:50, willchan wrote:
> You should probably also print out the errno (or whatever it is in windows,
> WSAGetLastError() or something).

Done.

http://codereview.chromium.org/199048/diff/6001/7001#newcode463
Line 463: DCHECK(!rv) << "Could not set socket send buffer size";
On 2009/09/09 19:49:50, willchan wrote:
> Ditto here.

Done.

http://codereview.chromium.org/199048/diff/6001/7002
File net/socket/tcp_client_socket_win.h (right):

http://codereview.chromium.org/199048/diff/6001/7002#newcode39
Line 39: virtual bool SetSendBufferSize(int32 size);
On 2009/09/09 19:49:50, willchan wrote:
> You should have a newline before the "private:" section.

Done.