Issue 1987009: Add routing info and unrecoverable error info to about:sync

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1987009: Add routing info and unrecoverable error info to about:sync (Closed)

Created:
10 years, 7 months ago by tim (not reviewing)

Modified:
9 years, 6 months ago

Reviewers:
akalin

CC:
chromium-reviews, ncarter (slow), ben+cc_chromium.org, tim (not reviewing), idana

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Add routing info and unrecoverable error info to about:sync. (Needs http://codereview.chromium.org/2002012 to build). BUG=42695 TEST=manually visit about:sync Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49258

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+134 lines, -28 lines)			Patch
M	chrome/browser/browser_about_handler.cc	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/engine/model_safe_worker.h	View	1 2	3 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/sync/engine/model_safe_worker.cc	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/resources/about_sync.html	View	1	4 chunks	+71 lines, -27 lines	0 comments	Download
M	chrome/browser/sync/syncable/model_type.h	View	1 2 3	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/syncable/model_type.cc	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

akalin

10 years, 6 months ago (2010-06-08 21:13:44 UTC) #2

On 2010/06/07 00:31:08, timsteele wrote:
> 

LGTM, but fix lint errors re. string include