Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1584)

Unified Diff: chrome/browser/browser_about_handler.cc

Issue 1987009: Add routing info and unrecoverable error info to about:sync (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/engine/model_safe_worker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_about_handler.cc
===================================================================
--- chrome/browser/browser_about_handler.cc (revision 49216)
+++ chrome/browser/browser_about_handler.cc (working copy)
@@ -642,6 +642,28 @@
AddBoolSyncDetail(details, L"Invalid Store", full_status.invalid_store);
AddIntSyncDetail(details, L"Max Consecutive Errors",
full_status.max_consecutive_errors);
+
+ if (service->unrecoverable_error_detected()) {
+ strings.Set(L"unrecoverable_error_detected", new FundamentalValue(true));
+ strings.SetString(L"unrecoverable_error_message",
+ service->unrecoverable_error_message());
+ tracked_objects::Location loc(service->unrecoverable_error_location());
+ std::string location_str;
+ loc.Write(true, true, &location_str);
+ strings.SetString(L"unrecoverable_error_location", location_str);
+ }
+
+ browser_sync::ModelSafeRoutingInfo routes;
+ service->backend()->GetModelSafeRoutingInfo(&routes);
+ ListValue* routing_info = new ListValue();
+ strings.Set(L"routing_info", routing_info);
+ browser_sync::ModelSafeRoutingInfo::const_iterator it = routes.begin();
+ for (; it != routes.end(); ++it) {
+ DictionaryValue* val = new DictionaryValue;
+ val->SetString(L"model_type", ModelTypeToString(it->first));
+ val->SetString(L"group", ModelSafeGroupToString(it->second));
+ routing_info->Append(val);
+ }
}
static const base::StringPiece sync_html(
« no previous file with comments | « no previous file | chrome/browser/sync/engine/model_safe_worker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698