Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 198034: Stick all of the WebKit API enum compile asserts in one file.... (Closed)

Created:
11 years, 3 months ago by darin (slow to review)
Modified:
11 years, 3 months ago
CC:
chromium-reviews_googlegroups.com, darin (slow to review), fbarchard, awong, Alpha Left Google
Visibility:
Public.

Description

Stick all of the WebKit API enum compile asserts in one file. I did this for two reasons: 1) For enumeration types that are not defined within a class, and therefore do not have a corresponding .cpp file, we have an obvious place to put the compile asserts. 2) It keeps these assertions out of the more interesting code, which should help with readability a bit. R=jorlow BUG=none TEST=none

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -142 lines) Patch
M webkit/api/src/ApplicationCacheHost.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M webkit/api/src/AssertMatchingEnums.cpp View 1 chunk +102 lines, -7 lines 0 comments Download
M webkit/api/src/ChromiumBridge.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M webkit/api/src/NotificationPresenterImpl.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M webkit/api/src/WebCursorInfo.cpp View 1 chunk +0 lines, -49 lines 0 comments Download
M webkit/api/src/WebMediaPlayerClientImpl.cpp View 3 chunks +0 lines, -47 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
darin (slow to review)
11 years, 3 months ago (2009-09-04 23:18:05 UTC) #1
michaeln
lgtm
11 years, 3 months ago (2009-09-05 17:36:41 UTC) #2
darin (slow to review)
Thanks for looking at this Michael!-Darin On Sat, Sep 5, 2009 at 10:36 AM, <michaeln@chromium.org> ...
11 years, 3 months ago (2009-09-06 07:28:56 UTC) #3
scherkus (not reviewing)
11 years, 3 months ago (2009-09-08 20:15:34 UTC) #4
late to the party -- but media stuff is good

http://codereview.chromium.org/198034/diff/1/5
File webkit/api/src/WebMediaPlayerClientImpl.cpp (right):

http://codereview.chromium.org/198034/diff/1/5#newcode360
Line 360: case WebMimeRegistry::MayBeSupported:
Hmm... it looks like we can't do the same trick here

I remember we decided that WebMimeRegistry will always return a SupportsType
enum value, which so happens to coincide with WebCore::MediaPlayer's enums --
but they are technically separate and we'll keep them that way

Powered by Google App Engine
This is Rietveld 408576698