Add the tooltips for the toolbar buttons....

Add the tooltips for the toolbar buttons.
Dynamically set the tooltip for the star button based on state.
  - make bookmark
  - edit bookmark
Build the go button tooltip when asked so it can react to state of the tab and of the url bar.
  - stop state
  - got to url state
  - do search state

BUG=21089
TEST=All the buttons in the toolbar should have localized tooltips.  The star's depends on it's state.  To go button will be stop, goto site, or do search (link windows).

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25857

[Scott Hess - ex-Googler, 2009-09-05 00:00:17]

http://codereview.chromium.org/198027/diff/1/4
File chrome/browser/cocoa/toolbar_controller.mm (right):

http://codereview.chromium.org/198027/diff/1/4#newcode495
Line 495: performSelector:@selector(editViewMac)];
Sorry - I think you mis-understood my suggestion.  From ToolbarController,
locationBarView_->edit_view_ is this same object.

Looking at the rest of the code, would it make sense to push everything from
currentText to the end into a method on LocationBarViewMac? 
edit_view_->GetText() would be what you want for currentText16, I think.

[TVL, 2009-09-09 17:03:22]

http://codereview.chromium.org/198027/diff/1/4
File chrome/browser/cocoa/toolbar_controller.mm (right):

http://codereview.chromium.org/198027/diff/1/4#newcode495
Line 495: performSelector:@selector(editViewMac)];
On 2009/09/05 00:00:17, shess wrote:
> Looking at the rest of the code, would it make sense to push everything from
> currentText to the end into a method on LocationBarViewMac? 

The code is following the linear flow in the go button for views (comment at the
start of the function), if it makes more sense in the mac breakdown to split it,
that's fine.  I'll happily defer to you two on that.  :)

[Scott Hess - ex-Googler, 2009-09-09 17:16:46]

http://codereview.chromium.org/198027/diff/1/4
File chrome/browser/cocoa/toolbar_controller.mm (right):

http://codereview.chromium.org/198027/diff/1/4#newcode495
Line 495: performSelector:@selector(editViewMac)];
On 2009/09/09 17:03:22, TVL wrote:
> On 2009/09/05 00:00:17, shess wrote:
> > Looking at the rest of the code, would it make sense to push everything from
> > currentText to the end into a method on LocationBarViewMac? 
> 
> The code is following the linear flow in the go button for views (comment at
the
> start of the function), if it makes more sense in the mac breakdown to split
it,
> that's fine.  I'll happily defer to you two on that.  :)

Hmm.  That's a quality argument.  My suggestion is mostly based around seeing
somewhat similar code in location_bar_view_mac.mm, and that that code already is
poking these bits (editModel->keyword(), ->is_keyword_hint(), etc), and is
already including all of your added #include files.

That said, I've never been able to figure out if the breakdown of UI controls
across the location-bar and toolbar code is intentional, random, or something in
between.

[TVL, 2009-09-09 17:27:17]

diffs update with your other suggestions.

[Scott Hess - ex-Googler, 2009-09-09 17:45:06]

LGTM.

Looking at the code, I feel like something somewhere needs refactoring :-).

On 2009/09/09 17:27:17, TVL wrote:
> diffs update with your other suggestions.