* Fix seg fault in deleting view from RemoveTabAtIndex...

* Fix seg fault in deleting view from RemoveTabAtIndex
* move initialization of tabbed page to NativeControlCreated

[sky, 2009-09-03 23:09:38]

http://codereview.chromium.org/198010/diff/4002/4003
File views/controls/tabbed_pane/native_tabbed_pane_gtk.cc (right):

http://codereview.chromium.org/198010/diff/4002/4003#newcode67
Line 67: g_object_ref(page);
Wouldn't this mean we never delete the WidgetGtk you created on insertion? I
suspect you'll need to reset the content view of the WidgetGtk, that way it
won't get deleted when you remove the widget.

[oshima, 2009-09-09 02:17:34]

http://codereview.chromium.org/198010/diff/4002/4003
File views/controls/tabbed_pane/native_tabbed_pane_gtk.cc (right):

http://codereview.chromium.org/198010/diff/4002/4003#newcode67
Line 67: g_object_ref(page);
On 2009/09/03 23:09:38, sky wrote:
> Wouldn't this mean we never delete the WidgetGtk you created on insertion? I
> suspect you'll need to reset the content view of the WidgetGtk, that way it
> won't get deleted when you remove the widget.

WidgetGtk delete itself when native_view is deleted, but the original CL had a
bug. I had to keep is the view, but not just native gtk widget. Please see
updated CL.

[sky, 2009-09-09 03:23:15]

LGTM

http://codereview.chromium.org/198010/diff/4005/5004
File views/controls/tabbed_pane/native_tabbed_pane_gtk.cc (right):

http://codereview.chromium.org/198010/diff/4005/5004#newcode73
Line 73: // widget delete itself when native_view is deleted.
nit: delete -> deletes

[sky, 2009-09-09 16:34:35]

Landed in r25730

On Tue, Sep 8, 2009 at 8:23 PM, <sky@chromium.org> wrote:
> LGTM
>
>
> http://codereview.chromium.org/198010/diff/4005/5004
> File views/controls/tabbed_pane/native_tabbed_pane_gtk.cc (right):
>
> http://codereview.chromium.org/198010/diff/4005/5004#newcode73
> Line 73: // widget delete itself when native_view is deleted.
> nit: delete -> deletes
>
> http://codereview.chromium.org/198010
>