Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 19753: Changed the debugger API to allow only one debug event listener to be registe... (Closed)

Created:
11 years, 10 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Changed the debugger API to allow only one debug event listener to be registered. The public API now only has SetDebugEventListener instead of AddDebugEventListener and RemoveDebugEventListener. Moved the registrered debug event listener from the context to a global handle in the Debugger class. Storing it in the context did not make much sense. Changed a lot of tests to handle the API change. BUG=1242707 Committed: http://code.google.com/p/v8/source/detail?r=1212

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -185 lines) Patch
M include/v8-debug.h View 2 chunks +5 lines, -11 lines 0 comments Download
M src/api.cc View 1 chunk +9 lines, -65 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/contexts.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/d8.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/debug.cc View 5 chunks +50 lines, -29 lines 0 comments Download
M src/debug-delay.js View 1 chunk +5 lines, -7 lines 0 comments Download
M src/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime.cc View 1 chunk +9 lines, -22 lines 0 comments Download
M test/mjsunit/debug-backtrace.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-backtrace-text.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-changebreakpoint.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-clearbreakpoint.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-conditional-breakpoints.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-constructor.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/debug-continue.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-enable-disable-breakpoints.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-evaluate.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-evaluate-arguments.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-evaluate-locals.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-evaluate-recursive.js View 2 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/debug-evaluate-with.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-event-listener.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/debug-handle.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-ignore-breakpoints.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-mirror-cache.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-multiple-breakpoints.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-scripts-request.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-setbreakpoint.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-step.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/debug-step-stub-callfunction.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/debug-stepin-constructor.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-1081309.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-1170187.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-998565.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
11 years, 10 months ago (2009-02-02 15:48:24 UTC) #1
Mads Ager (chromium)
LGTM. This change probably needs a Chromium change as well. Could you prepare that and ...
11 years, 10 months ago (2009-02-03 07:24:40 UTC) #2
Søren Thygesen Gjesse
11 years, 10 months ago (2009-02-03 07:47:28 UTC) #3
I will prepare a Chromium patch.

http://codereview.chromium.org/19753/diff/1/28
File include/v8.h (right):

http://codereview.chromium.org/19753/diff/1/28#newcode2127
Line 2127: /**
On 2009/02/03 07:24:40, Mads Ager wrote:
> Accidental edit?  This file can be left out of the changelist.

Done.

Powered by Google App Engine
This is Rietveld 408576698