Return ERR_FILE_NOT_FOUND from FtpNetworkTransaction when we can.

Return ERR_FILE_NOT_FOUND from FtpNetworkTransaction when we can.

This way it provides more specific error code for the user.

TEST=Covered by net_unittests.
http://crbug.com/20405

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25771

[wtc, 2009-09-09 01:34:28]

This CL looks good to me, but I'd like you to explain
it to me tomorrow.  I don't understand why we set the
ERR_FILE_NOT_FOUND error in CWD rather than RETR.

You can check this CL in before we meet.

http://codereview.chromium.org/197050/diff/1/2
File net/ftp/ftp_network_transaction.cc (right):

http://codereview.chromium.org/197050/diff/1/2#newcode908
Line 908: if (retr_failed_ && response.status_code == 550)
Why do we need to test retr_failed_ here?  How is the
failed RETR command related to the CWD command that we're
processing here?

[Paweł Hajdan Jr., 2009-09-09 17:37:01]

You're right, it's not clear at all. Please see the added comment.

[wtc, 2009-09-09 18:41:31]

http://codereview.chromium.org/197050/diff/1004/5
File net/ftp/ftp_network_transaction.cc (right):

http://codereview.chromium.org/197050/diff/1004/5#newcode837
Line 837: retr_failed_ = true;
My question is: are we going to try the CWD command next?
I still don't see the relation between RETR and CWD.