Return ERR_FILE_NOT_FOUND from FtpNetworkTransaction when we can.

net/ftp/ftp_network_transaction_unittest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/ftp/ftp_network_transaction.h"
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <ws2tcpip.h>
@@ skipping 285 matching lines @@
 
   virtual MockWriteResult OnWrite(const std::string& data) {
     if (InjectFault())
       return MockWriteResult(true, data.length());
     switch (state()) {
       case PRE_PASV2:
         return Verify("PASV\r\n", data, PRE_CWD,
                       "227 Entering Passive Mode (127,0,0,1,123,456)\r\n");
       case PRE_CWD:
         return Verify("CWD /file\r\n", data, PRE_QUIT,
-                      "500 file is a directory\r\n");
+                      "550 file is a directory\r\n");
       default:
         return FtpMockControlSocketFileDownload::OnWrite(data);
     }
   }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(FtpMockControlSocketFileDownloadRetrFail);
 };
 
 class FtpMockControlSocketEvilPasv : public FtpMockControlSocketFileDownload {
@@ skipping 360 matching lines @@
 TEST_F(FtpNetworkTransactionTest, DirectoryTransactionFailCwd) {
   FtpMockControlSocketDirectoryListing ctrl_socket;
   TransactionFailHelper(&ctrl_socket,
                         "ftp://host",
                         FtpMockControlSocket::PRE_CWD,
                         FtpMockControlSocket::PRE_QUIT,
                         "500 failed cwd\r\n",
                         ERR_FAILED);
 }
 
+TEST_F(FtpNetworkTransactionTest, DirectoryTransactionFileNotFound) {
+  FtpMockControlSocketDirectoryListing ctrl_socket;
+  TransactionFailHelper(&ctrl_socket,
+                        "ftp://host",
+                        FtpMockControlSocket::PRE_CWD,
+                        FtpMockControlSocket::PRE_QUIT,
+                        "550 cannot open file\r\n",
+                        ERR_FILE_NOT_FOUND);
+}
+
 TEST_F(FtpNetworkTransactionTest, DirectoryTransactionFailList) {
   FtpMockControlSocketDirectoryListing ctrl_socket;
   TransactionFailHelper(&ctrl_socket,
                         "ftp://host",
                         FtpMockControlSocket::PRE_LIST,
                         FtpMockControlSocket::PRE_QUIT,
                         "500 failed list\r\n",
                         ERR_FAILED);
 }
 
@@ skipping 65 matching lines @@
                         FtpMockControlSocket::PRE_RETR,
                         "500 failed mdtm\r\n",
                         OK);
 }
 
 TEST_F(FtpNetworkTransactionTest, DownloadTransactionFailRetr) {
   FtpMockControlSocketFileDownloadRetrFail ctrl_socket;
   TransactionFailHelper(&ctrl_socket,
                         "ftp://host/file",
                         FtpMockControlSocket::PRE_RETR,
+                        FtpMockControlSocket::PRE_QUIT,
+                        "500 failed retr\r\n",
+                        ERR_FAILED);
+}
+
+TEST_F(FtpNetworkTransactionTest, DownloadTransactionFileNotFound) {
+  FtpMockControlSocketFileDownloadRetrFail ctrl_socket;
+  TransactionFailHelper(&ctrl_socket,
+                        "ftp://host/file",
+                        FtpMockControlSocket::PRE_RETR,
                         FtpMockControlSocket::PRE_PASV2,
-                        "500 failed retr\r\n",
-                        ERR_FAILED);
+                        "550 cannot open file\r\n",
+                        ERR_FILE_NOT_FOUND);
 }
 
 }  // namespace net