Issue 197044: Display symlinks on FTP directory listings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 197044: Display symlinks on FTP directory listings. (Closed)

Created:
11 years, 3 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Display symlinks on FTP directory listings. TEST=See bug. http://crbug.com/21006 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25729

Patch Set 1 #

Total comments: 3

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -0 lines)			Patch
	M	net/url_request/url_request_new_ftp_job.cc	View		1 chunk	+18 lines, -0 lines	3 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wtc

11 years, 3 months ago (2009-09-09 01:25:46 UTC) #2

LGTM.  Please fix a style nit before you check this in.

http://codereview.chromium.org/197044/diff/1/2
File net/url_request/url_request_new_ftp_job.cc (right):

http://codereview.chromium.org/197044/diff/1/2#newcode268
Line 268: {
Nit: the braces should be placed like this:

  case net::FTP_TYPE_SYMLINK: {
    std::string filename(result.fe_fname, result.fe_fnlen);
    ...
    break;
  }

See
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Loops_and_Swit...

http://codereview.chromium.org/197044/diff/1/2#newcode271
Line 271: // Parsers for styles 'U' and 'W' handle sequence " -> " themselves.
What does "handle sequence" mean?

http://codereview.chromium.org/197044/diff/1/2#newcode278
Line 278: if (StringToInt64(result.fe_size, &file_size)) {
Do you know if the result.fe_size field makes sense for a
symlink?  I'm wondering if we should pass 0 as the 'size'
argument to net::GetDirectoryListingEntry, as we do in the
net::FTP_TYPE_DIRECTORY case above.

Expand Messages | Collapse Messages