Display symlinks on FTP directory listings.

net/url_request/url_request_new_ftp_job.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_new_ftp_job.h"
 
 #include "base/compiler_specific.h"
 #include "base/file_version_info.h"
 #include "base/message_loop.h"
 #include "base/sys_string_conversions.h"
@@ skipping 247 matching lines @@
             base::Time::FromLocalExploded(result.fe_time)));
         break;
       case net::FTP_TYPE_FILE:
         if (StringToInt64(result.fe_size, &file_size))
           file_entry.append(net::GetDirectoryListingEntry(
               RawByteSequenceToFilename(result.fe_fname, encoding_),
               result.fe_fname, false, file_size,
               base::Time::FromLocalExploded(result.fe_time)));
         break;
       case net::FTP_TYPE_SYMLINK:
+        {

[wtc, 2009/09/09 01:25:46]

Nit: the braces should be placed like this:

  case net::FTP_TYPE_SYMLINK: {
    std::string filename(result.fe_fname, result.fe_fnlen);
    ...
    break;
  }

See
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Loops_and_Swit...

+          std::string filename(result.fe_fname, result.fe_fnlen);
+
+          // Parsers for styles 'U' and 'W' handle sequence " -> " themselves.

[wtc, 2009/09/09 01:25:46]

What does "handle sequence" mean?

+          if (state.lstyle != 'U' && state.lstyle != 'W') {
+            std::string::size_type offset = filename.find(" -> ");
+            if (offset != std::string::npos)
+              filename = filename.substr(0, offset);
+          }
+
+          if (StringToInt64(result.fe_size, &file_size)) {

[wtc, 2009/09/09 01:25:46]

Do you know if the result.fe_size field makes sense for a
symlink?  I'm wondering if we should pass 0 as the 'size'
argument to net::GetDirectoryListingEntry, as we do in the
net::FTP_TYPE_DIRECTORY case above.

+            file_entry.append(net::GetDirectoryListingEntry(
+                RawByteSequenceToFilename(filename.c_str(), encoding_),
+                filename, false, file_size,
+                base::Time::FromLocalExploded(result.fe_time)));
+          }
+        }
+        break;
       case net::FTP_TYPE_JUNK:
       case net::FTP_TYPE_COMMENT:
         break;
       default:
         break;
     }
   }
   LogFtpServerType(state);
   directory_html_.append(file_entry);
   size_t bytes_to_copy = std::min(static_cast<size_t>(buf_size),
@@ skipping 121 matching lines @@
   MessageLoop::current()->PostTask(FROM_HERE, NewRunnableMethod(
       this, &URLRequestNewFtpJob::OnStartCompleted, rv));
 }
 
 void URLRequestNewFtpJob::DestroyTransaction() {
   DCHECK(transaction_.get());
 
   transaction_.reset();
   response_info_ = NULL;
 }