Fleshes out the tooltip implementation for views on Gtk. It doesn't...

Fleshes out the tooltip implementation for views on Gtk. It doesn't
support explicit positioning of the tooltip as windows does. That'll
have to be added later.

BUG=none
TEST=make sure tooltips still work correctly on windows


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25635

[jcampan, 2009-09-08 16:43:07]

http://codereview.chromium.org/197031/diff/1/8
File views/widget/tooltip_manager_gtk.cc (right):

http://codereview.chromium.org/197031/diff/1/8#newcode21
Line 21: // Create a realize a tooltip widget and extract the from it.
Comment wording.

http://codereview.chromium.org/197031/diff/1/8#newcode22
Line 22: GtkWidget* window = gtk_window_new (GTK_WINDOW_POPUP);
Remove extra-space "gtk_window_new ("

http://codereview.chromium.org/197031/diff/1/8#newcode96
Line 96: gtk_tooltip_set_custom(tooltip, NULL);
Don't you need to delete label?

[sky, 2009-09-08 16:59:06]

All updated with new snapshot uploaded

http://codereview.chromium.org/197031/diff/1/8
File views/widget/tooltip_manager_gtk.cc (right):

http://codereview.chromium.org/197031/diff/1/8#newcode96
Line 96: gtk_tooltip_set_custom(tooltip, NULL);
On 2009/09/08 16:43:07, jcampan wrote:
> Don't you need to delete label?

The tooltip ends up owning it. I've added a comment to this effect.

[jcampan, 2009-09-08 17:12:04]

LGTM