Fleshes out the tooltip implementation for views on Gtk. It doesn't...

chrome/browser/views/toolbar_view.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/toolbar_view.h"
 
 #include <string>
 
 #include "app/drag_drop_types.h"
 #include "app/gfx/canvas.h"
 #include "app/l10n_util.h"
 #include "app/os_exchange_data.h"
 #include "app/resource_bundle.h"
 #include "base/command_line.h"
+#include "base/keyboard_codes.h"
 #include "base/logging.h"
 #include "base/path_service.h"
 #include "chrome/app/chrome_dll_resource.h"
 #include "chrome/browser/back_forward_menu_model_views.h"
 #include "chrome/browser/bookmarks/bookmark_model.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browser_window.h"
 #include "chrome/browser/character_encoding.h"
 #include "chrome/browser/encoding_menu_controller.h"
@@ skipping 14 matching lines @@
 #include "chrome/common/notification_service.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/pref_service.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "net/base/net_util.h"
 #include "views/background.h"
 #include "views/controls/button/button_dropdown.h"
 #include "views/controls/label.h"
+#include "views/widget/tooltip_manager.h"
 #if defined(OS_WIN)
 #include "views/drag_utils.h"
-#include "views/widget/tooltip_manager.h"
 #endif
 #include "views/window/non_client_view.h"
 #include "views/window/window.h"
 
 static const int kControlHorizOffset = 4;
 static const int kControlVertOffset = 6;
 static const int kControlIndent = 3;
 static const int kStatusBubbleWidth = 480;
 
 // Separation between the location bar and the menus.
@@ skipping 515 matching lines @@
   LoadCenterStackImages();
   LoadRightSideControlsImages();
 }
 
 void ToolbarView::ShowContextMenu(int x, int y, bool is_mouse_gesture) {
   if (acc_focused_view_)
     acc_focused_view_->ShowContextMenu(x, y, is_mouse_gesture);
 }
 
 void ToolbarView::DidGainFocus() {
-#if defined(OS_WIN)
   // Check to see if MSAA focus should be restored to previously focused button,
   // and if button is an enabled, visibled child of toolbar.
   if (!acc_focused_view_ ||
       (acc_focused_view_->GetParent()->GetID() != VIEW_ID_TOOLBAR) ||
       !acc_focused_view_->IsEnabled() ||
       !acc_focused_view_->IsVisible()) {
     // Find first accessible child (-1 to start search at parent).
     int first_acc_child = GetNextAccessibleViewIndex(-1, false);
 
     // No buttons enabled or visible.
@@ skipping 11 matching lines @@
     acc_focused_view_->SetHotTracked(true);
 
     // Show the tooltip for the view that got the focus.
     if (GetWidget()->GetTooltipManager())
       GetWidget()->GetTooltipManager()->ShowKeyboardTooltip(acc_focused_view_);
 
     // Update focused_view with MSAA-adjusted child id.
     view_index = acc_focused_view_->GetID();
   }
 
+#if defined(OS_WIN)
   gfx::NativeView wnd = GetWidget()->GetNativeView();
 
   // Notify Access Technology that there was a change in keyboard focus.
   ::NotifyWinEvent(EVENT_OBJECT_FOCUS, wnd, OBJID_CLIENT,
                    static_cast<LONG>(view_index));
 #else
   // TODO(port): deal with toolbar a11y focus.
   NOTIMPLEMENTED();
 #endif
 }
 
 void ToolbarView::WillLoseFocus() {
-#if defined(OS_WIN)
   if (acc_focused_view_) {
     // Resetting focus state.
     acc_focused_view_->SetHotTracked(false);
   }
   // Any tooltips that are active should be hidden when toolbar loses focus.
   if (GetWidget() && GetWidget()->GetTooltipManager())
     GetWidget()->GetTooltipManager()->HideKeyboardTooltip();
-#else
-  // TODO(port): deal with toolbar a11y focus.
-  NOTIMPLEMENTED();
-#endif
 }
 
 bool ToolbarView::OnKeyPressed(const views::KeyEvent& e) {
-#if defined(OS_WIN)
   // Paranoia check, button should be initialized upon toolbar gaining focus.
   if (!acc_focused_view_)
     return false;
 
   int focused_view = GetChildIndex(acc_focused_view_);
   int next_view = focused_view;
 
   switch (e.GetCharacter()) {
-    case VK_LEFT:
+    case base::VKEY_LEFT:
       next_view = GetNextAccessibleViewIndex(focused_view, true);
       break;
-    case VK_RIGHT:
+    case base::VKEY_RIGHT:
       next_view = GetNextAccessibleViewIndex(focused_view, false);
       break;
-    case VK_DOWN:
-    case VK_RETURN:
-      // VK_SPACE is already handled by the default case.
+    case base::VKEY_DOWN:
+    case base::VKEY_RETURN:
+      // VKEY_SPACE is already handled by the default case.
       if (acc_focused_view_->GetID() == VIEW_ID_PAGE_MENU ||
           acc_focused_view_->GetID() == VIEW_ID_APP_MENU) {
         // If a menu button in toolbar is activated and its menu is displayed,
         // then active tooltip should be hidden.
         if (GetWidget()->GetTooltipManager())
           GetWidget()->GetTooltipManager()->HideKeyboardTooltip();
         // Safe to cast, given to above view id check.
         static_cast<views::MenuButton*>(acc_focused_view_)->Activate();
         if (!acc_focused_view_) {
           // Activate triggered a focus change, don't try to change focus.
@@ skipping 16 matching lines @@
   if (next_view != focused_view) {
     // Remove hot-tracking from old focused button.
     acc_focused_view_->SetHotTracked(false);
 
     // All is well, update the focused child member variable.
     acc_focused_view_ = GetChildViewAt(next_view);
 
     // Hot-track new focused button.
     acc_focused_view_->SetHotTracked(true);
 
-    // Retrieve information to generate an MSAA focus event.
-    int view_id = acc_focused_view_->GetID();
-    gfx::NativeView wnd = GetWidget()->GetNativeView();
-
     // Show the tooltip for the view that got the focus.
     if (GetWidget()->GetTooltipManager()) {
       GetWidget()->GetTooltipManager()->
           ShowKeyboardTooltip(GetChildViewAt(next_view));
     }
+#if defined(OS_WIN)
+    // Retrieve information to generate an MSAA focus event.
+    gfx::NativeView wnd = GetWidget()->GetNativeView();
+    int view_id = acc_focused_view_->GetID();
     // Notify Access Technology that there was a change in keyboard focus.
     ::NotifyWinEvent(EVENT_OBJECT_FOCUS, wnd, OBJID_CLIENT,
                      static_cast<LONG>(view_id));
+#else
+    NOTIMPLEMENTED();
+#endif
     return true;
   }
-#else
-  // TODO(port): deal with toolbar a11y focus.
-  NOTIMPLEMENTED();
-#endif
   return false;
 }
 
 bool ToolbarView::OnKeyReleased(const views::KeyEvent& e) {
   // Paranoia check, button should be initialized upon toolbar gaining focus.
   if (!acc_focused_view_)
     return false;
 
   // Have keys be handled by the views themselves.
   return acc_focused_view_->OnKeyReleased(e);
@@ skipping 371 matching lines @@
   app_menu_contents_->AddItem(IDC_ABOUT,
                               l10n_util::GetStringFUTF16(
                                   IDS_ABOUT,
                                   l10n_util::GetStringUTF16(IDS_PRODUCT_NAME)));
   app_menu_contents_->AddItemWithStringId(IDC_HELP_PAGE, IDS_HELP_PAGE);
   app_menu_contents_->AddSeparator();
   app_menu_contents_->AddItemWithStringId(IDC_EXIT, IDS_EXIT);
 
   app_menu_menu_.reset(new views::Menu2(app_menu_contents_.get()));
 }