base/string_util_unittest.cc - Issue 197018: Strip .plugin off of Mac plugin names when showing the crash info bar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/string_util_unittest.cc

Issue 197018: Strip .plugin off of Mac plugin names when showing the crash info bar. (Closed)

Patch Set: Add a test with the match in the middle Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/string_util_unittest.cc

diff --git a/base/string_util_unittest.cc b/base/string_util_unittest.cc

index 35c58d6668ac805a643244721ac1e13a59b9b35b..98f64bd1a15245621252e1602479110fb3632de5 100644

--- a/base/string_util_unittest.cc

+++ b/base/string_util_unittest.cc

@@ -1576,6 +1576,21 @@ TEST(StringUtilTest, StartsWith) {

EXPECT_TRUE(StartsWith(L"java", L"", true));

}

+TEST(StringUtilTest, EndsWith) {

+ EXPECT_TRUE(EndsWith(L"Foo.plugin", L".plugin", true));

+ EXPECT_FALSE(EndsWith(L"Foo.Plugin", L".plugin", true));

+ EXPECT_TRUE(EndsWith(L"Foo.plugin", L".plugin", false));

+ EXPECT_TRUE(EndsWith(L"Foo.Plugin", L".plugin", false));

+ EXPECT_FALSE(EndsWith(L".plug", L".plugin", true));

+ EXPECT_FALSE(EndsWith(L".plug", L".plugin", false));

+ EXPECT_FALSE(EndsWith(L"Foo.plugin Bar", L".plugin", true));

+ EXPECT_FALSE(EndsWith(L"Foo.plugin Bar", L".plugin", false));

+ EXPECT_FALSE(EndsWith(L"", L".plugin", false));

+ EXPECT_FALSE(EndsWith(L"", L".plugin", true));

+ EXPECT_TRUE(EndsWith(L"Foo.plugin", L"", false));

+ EXPECT_TRUE(EndsWith(L"Foo.plugin", L"", true));

Mark Mentovai 2009/09/04 18:09:00 I'd also add a few cases to test |str == search|,

TEST(StringUtilTest, GetStringFWithOffsets) {

std::vector<string16> subst;

subst.push_back(ASCIIToUTF16("1"));

« no previous file with comments | « base/string_util.cc ('k') | chrome/browser/tab_contents/tab_contents.cc » ('j') | no next file with comments »