Issue 19632: Make WebContentsView portable by using the native view types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19632: Make WebContentsView portable by using the native view types. (Closed)

Created:
11 years, 10 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Make WebContentsView portable by using the native view types. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8819

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -33 lines)			Patch
M	base/build/base_gfx.vcproj	View		2 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents.cc	View	1	4 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents_view.h	View	1	3 chunks	+10 lines, -12 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents_view_win.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents_view_win.cc	View	1	6 chunks	+11 lines, -10 lines	0 comments	Download

Total messages: 2 (0 generated)

Ben Goodger (Google)

11 years, 10 months ago (2009-01-28 19:15:32 UTC) #2

GetNativeContainer -> GetNativeView
GetNativeContent -> GetContentNativeView

and LGTM.