Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7117)

Unified Diff: chrome/browser/tab_contents/web_contents.cc

Issue 19632: Make WebContentsView portable by using the native view types. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/build/base_gfx.vcproj ('k') | chrome/browser/tab_contents/web_contents_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/web_contents.cc
===================================================================
--- chrome/browser/tab_contents/web_contents.cc (revision 8803)
+++ chrome/browser/tab_contents/web_contents.cc (working copy)
@@ -494,10 +494,10 @@
view_->CreateView();
}
HWND WebContents::GetContainerHWND() const {
- return view_->GetContainerHWND();
+ return view_->GetNativeView();
}
HWND WebContents::GetContentHWND() {
- return view_->GetContentHWND();
+ return view_->GetContentNativeView();
}
void WebContents::GetContainerBounds(gfx::Rect *out) const {
view_->GetContainerBounds(out);
@@ -573,8 +573,8 @@
// TODO(rocking): Use new asynchronous dialog boxes to prevent the SaveAs
// dialog blocking the UI thread. See bug: http://b/issue?id=1129694.
- if (SavePackage::GetSaveInfo(suggest_name, GetContainerHWND(), &param,
- profile()->GetDownloadManager()))
+ if (SavePackage::GetSaveInfo(suggest_name, view_->GetNativeView(),
+ &param, profile()->GetDownloadManager()))
SavePage(param.saved_main_file_path, param.dir, param.save_type);
}
@@ -997,6 +997,7 @@
const std::wstring& title,
const std::wstring& default_file,
const std::wstring& filter) {
+ // TODO(brettw) move this to the view.
HWND toplevel_hwnd = GetAncestor(GetContainerHWND(), GA_ROOT);
if (!select_file_dialog_.get())
select_file_dialog_ = SelectFileDialog::Create(this);
@@ -1144,7 +1145,7 @@
keyword,
url,
base_entry->favicon().url(),
- GetAncestor(view_->GetContainerHWND(), GA_ROOT),
+ GetAncestor(view_->GetNativeView(), GA_ROOT),
autodetected);
}
« no previous file with comments | « base/build/base_gfx.vcproj ('k') | chrome/browser/tab_contents/web_contents_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698