Issue 1963: Port the thread local storage unittest to Mac and linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1963: Port the thread local storage unittest to Mac and linux. (Closed)

Created:
12 years, 3 months ago by Paul Godavari

Modified:
9 years, 7 months ago

Reviewers:
Amanda Walker

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Port the thread local storage unittest to Mac and linux. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2101

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -39 lines)			Patch
M	base/SConscript	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	base/base.xcodeproj/project.pbxproj	View	1	4 chunks	+4 lines, -0 lines	0 comments	Download
M	base/thread_local_storage_unittest.cc	View	1	2 chunks	+47 lines, -38 lines	0 comments	Download

Total messages: 2 (0 generated)

Amanda Walker

12 years, 3 months ago (2008-09-11 23:11:05 UTC) #2

LGTM.  Cleaner and more readable--much improved all around.