| Index: base/thread_local_storage_unittest.cc
|
| ===================================================================
|
| --- base/thread_local_storage_unittest.cc (revision 2099)
|
| +++ base/thread_local_storage_unittest.cc (working copy)
|
| @@ -2,50 +2,52 @@
|
| // Use of this source code is governed by a BSD-style license that can be
|
| // found in the LICENSE file.
|
|
|
| +#if defined(OS_WIN)
|
| #include <windows.h>
|
| #include <process.h>
|
| +#endif
|
|
|
| +#include "base/simple_thread.h"
|
| #include "base/thread_local_storage.h"
|
| #include "testing/gtest/include/gtest/gtest.h"
|
|
|
| -// ignore warnings about ptr->int conversions that we use when
|
| +#if defined(OS_WIN)
|
| +// Ignore warnings about ptr->int conversions that we use when
|
| // storing ints into ThreadLocalStorage.
|
| #pragma warning(disable : 4311 4312)
|
| +#endif
|
|
|
| -namespace {
|
| - class ThreadLocalStorageTest : public testing::Test {
|
| - };
|
| -}
|
| +const int kInitialTlsValue = 0x5555;
|
| +static ThreadLocalStorage::Slot tls_slot(base::LINKER_INITIALIZED);
|
|
|
|
|
| -TEST(ThreadLocalStorageTest, Basics) {
|
| - ThreadLocalStorage::Slot slot;
|
| - slot.Set(reinterpret_cast<void*>(123));
|
| - int value = reinterpret_cast<int>(slot.Get());
|
| - EXPECT_EQ(value, 123);
|
| -}
|
| +class ThreadLocalStorageRunner : public base::DelegateSimpleThread::Delegate {
|
| + public:
|
| + explicit ThreadLocalStorageRunner(int* tls_value_ptr)
|
| + : tls_value_ptr_(tls_value_ptr) {}
|
|
|
| -const int kInitialTlsValue = 0x5555;
|
| -static ThreadLocalStorage::Slot tls_slot(base::LINKER_INITIALIZED);
|
| + virtual ~ThreadLocalStorageRunner() {}
|
|
|
| -unsigned __stdcall TLSTestThreadMain(void* param) {
|
| - // param contains the thread local storage index.
|
| - int *index = reinterpret_cast<int*>(param);
|
| - *index = kInitialTlsValue;
|
| + virtual void Run() {
|
| + *tls_value_ptr_ = kInitialTlsValue;
|
| + tls_slot.Set(tls_value_ptr_);
|
|
|
| - tls_slot.Set(index);
|
| + int *ptr = static_cast<int*>(tls_slot.Get());
|
| + EXPECT_EQ(ptr, tls_value_ptr_);
|
| + EXPECT_EQ(*ptr, kInitialTlsValue);
|
| + *tls_value_ptr_ = 0;
|
|
|
| - int *ptr = static_cast<int*>(tls_slot.Get());
|
| - EXPECT_EQ(ptr, index);
|
| - EXPECT_EQ(*ptr, kInitialTlsValue);
|
| - *index = 0;
|
| + ptr = static_cast<int*>(tls_slot.Get());
|
| + EXPECT_EQ(ptr, tls_value_ptr_);
|
| + EXPECT_EQ(*ptr, 0);
|
| + }
|
|
|
| - ptr = static_cast<int*>(tls_slot.Get());
|
| - EXPECT_EQ(ptr, index);
|
| - EXPECT_EQ(*ptr, 0);
|
| - return 0;
|
| -}
|
| + private:
|
| + int* tls_value_ptr_;
|
| + DISALLOW_COPY_AND_ASSIGN(ThreadLocalStorageRunner);
|
| +};
|
|
|
| +
|
| void ThreadLocalStorageCleanup(void *value) {
|
| int *ptr = reinterpret_cast<int*>(value);
|
| if (ptr)
|
| @@ -53,33 +55,40 @@
|
| }
|
|
|
|
|
| +TEST(ThreadLocalStorageTest, Basics) {
|
| + ThreadLocalStorage::Slot slot;
|
| + slot.Set(reinterpret_cast<void*>(123));
|
| + int value = reinterpret_cast<int>(slot.Get());
|
| + EXPECT_EQ(value, 123);
|
| +}
|
| +
|
| TEST(ThreadLocalStorageTest, TLSDestructors) {
|
| // Create a TLS index with a destructor. Create a set of
|
| // threads that set the TLS, while the destructor cleans it up.
|
| // After the threads finish, verify that the value is cleaned up.
|
| const int kNumThreads = 5;
|
| - HANDLE threads[kNumThreads];
|
| int values[kNumThreads];
|
| + ThreadLocalStorageRunner* thread_delegates[kNumThreads];
|
| + base::DelegateSimpleThread* threads[kNumThreads];
|
|
|
| tls_slot.Initialize(ThreadLocalStorageCleanup);
|
|
|
| // Spawn the threads.
|
| - for (int16 index = 0; index < kNumThreads; index++) {
|
| + for (int index = 0; index < kNumThreads; index++) {
|
| values[index] = kInitialTlsValue;
|
| - void *argument = static_cast<void*>(&(values[index]));
|
| - unsigned thread_id;
|
| - threads[index] = reinterpret_cast<HANDLE>(
|
| - _beginthreadex(NULL, 0, TLSTestThreadMain, argument, 0, &thread_id));
|
| - EXPECT_NE(threads[index], (HANDLE)NULL);
|
| + thread_delegates[index] = new ThreadLocalStorageRunner(&values[index]);
|
| + threads[index] = new base::DelegateSimpleThread(thread_delegates[index],
|
| + "tls thread");
|
| + threads[index]->Start();
|
| }
|
|
|
| // Wait for the threads to finish.
|
| for (int index = 0; index < kNumThreads; index++) {
|
| - DWORD rv = WaitForSingleObject(threads[index], 60*1000);
|
| - EXPECT_EQ(rv, WAIT_OBJECT_0); // verify all threads finished
|
| + threads[index]->Join();
|
| + delete threads[index];
|
| + delete thread_delegates[index];
|
|
|
| - // verify that the destructor was called and that we reset.
|
| + // Verify that the destructor was called and that we reset.
|
| EXPECT_EQ(values[index], kInitialTlsValue);
|
| }
|
| }
|
| -
|
|
|