Issue 196117: Update WebKit to r48388...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196117: Update WebKit to r48388... (Closed)

Created:
11 years, 3 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Update WebKit to r48388 This commit introduces a failing webgl test. I added a skip for all webgl tests. TBR=brettw BUG=21852 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26202

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	webkit/tools/layout_tests/test_expectations.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

11 years, 3 months ago (2009-09-15 15:38:09 UTC) #2

LGTM

On Tue, Sep 15, 2009 at 12:04 AM,  <darin@chromium.org> wrote:
> Reviewers: brettw,
>
> Description:
> Update WebKit to r48388
>
> This commit introduces a failing webgl test. =A0I added a skip for
> all webgl tests.
>
> TBR=3Dbrettw
> BUG=3D21852
> TEST=3Dnone
>
>
> Please review this at http://codereview.chromium.org/196117
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 DEPS
> =A0M =A0 =A0 webkit/tools/layout_tests/test_expectations.txt
>
>
> Index: webkit/tools/layout_tests/test_expectations.txt
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- webkit/tools/layout_tests/test_expectations.txt =A0 =A0 (revision 262=
01)
> +++ webkit/tools/layout_tests/test_expectations.txt =A0 =A0 (working copy=
)
> @@ -114,6 +114,9 @@
> =A0// Depends on page cache, as far as I can tell.
> =A0WONTFIX SKIP BUG10635 :
> LayoutTests/fast/events/pageshow-pagehide-on-back-cached.html =3D TIMEOUT=
 FAIL
>
> +// No support for WebGL yet
> +BUG21852 SKIP : LayoutTests/fast/canvas/webgl =3D FAIL
> +
> =A0// -----------------------------------------------------------------
> =A0// FAILING TESTS
> =A0// -----------------------------------------------------------------
> Index: DEPS
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- DEPS =A0 =A0 =A0 =A0(revision 26201)
> +++ DEPS =A0 =A0 =A0 =A0(working copy)
> @@ -1,7 +1,7 @@
> =A0vars =3D {
> =A0 "webkit_trunk":
> =A0 =A0 "http://svn.webkit.org/repository/webkit/trunk",
> - =A0"webkit_revision": "48371",
> + =A0"webkit_revision": "48388",
> =A0}
>
> =A0deps =3D {
>
>
>

Expand Messages | Collapse Messages