This CL adds a test to insure we are not regressing on http://crbug.com/19941...

chrome/test/ui_test_utils.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/ui_test_utils.h"
 
 #include "base/json_reader.h"
 #include "base/message_loop.h"
 #include "base/path_service.h"
 #include "base/process_util.h"
@@ skipping 212 matching lines @@
   }
 
  private:
   NotificationRegistrar registrar_;
 
   AppModalDialog* dialog_;
 
   DISALLOW_COPY_AND_ASSIGN(AppModalDialogObserver);
 };
 
-class CrashedRenderProcessObserver : public NotificationObserver {
+template <class T>
+class SimpleNotificationObserver : public NotificationObserver {
  public:
-  explicit CrashedRenderProcessObserver(RenderProcessHost* rph) {
-    registrar_.Add(this, NotificationType::RENDERER_PROCESS_CLOSED,
-                   Source<RenderProcessHost>(rph));
+  SimpleNotificationObserver(NotificationType notification_type,
+                             T* source) {
+    registrar_.Add(this, notification_type, Source<T>(source));
     ui_test_utils::RunMessageLoop();
   }
 
   virtual void Observe(NotificationType type,
                        const NotificationSource& source,
                        const NotificationDetails& details) {
-    if (type == NotificationType::RENDERER_PROCESS_CLOSED) {
-      MessageLoopForUI::current()->Quit();
-    } else {
-      NOTREACHED();
-    }
+    MessageLoopForUI::current()->Quit();
   }
 
  private:
   NotificationRegistrar registrar_;
 
-  DISALLOW_COPY_AND_ASSIGN(CrashedRenderProcessObserver);
+  DISALLOW_COPY_AND_ASSIGN(SimpleNotificationObserver);
 };
 
 }  // namespace
 
 void RunMessageLoop() {
   MessageLoopForUI* loop = MessageLoopForUI::current();
   bool did_allow_task_nesting = loop->NestableTasksAllowed();
   loop->SetNestableTasksAllowed(true);
 #if defined(TOOLKIT_VIEWS)
   views::AcceleratorHandler handler;
@@ skipping 36 matching lines @@
 
 void WaitForNavigation(NavigationController* controller) {
   WaitForNavigations(controller, 1);
 }
 
 void WaitForNavigations(NavigationController* controller,
                         int number_of_navigations) {
   NavigationNotificationObserver observer(controller, number_of_navigations);
 }
 
+void WaitForNewTab(Browser* browser) {
+  SimpleNotificationObserver<Browser>
+      new_tab_observer(NotificationType::TAB_ADDED, browser);
+}
+
+void WaitForLoadStop(NavigationController* controller) {
+  SimpleNotificationObserver<NavigationController>
+      new_tab_observer(NotificationType::LOAD_STOP, controller);
+}
+
 void NavigateToURL(Browser* browser, const GURL& url) {
   NavigateToURLBlockUntilNavigationsComplete(browser, url, 1);
 }
 
 void NavigateToURLBlockUntilNavigationsComplete(Browser* browser,
                                                 const GURL& url,
                                                 int number_of_navigations) {
   NavigationController* controller =
       &browser->GetSelectedTabContents()->controller();
   browser->OpenURL(url, GURL(), CURRENT_TAB, PageTransition::TYPED);
@@ skipping 80 matching lines @@
 }
 
 AppModalDialog* WaitForAppModalDialog() {
   AppModalDialogObserver observer;
   return observer.WaitForAppModalDialog();
 }
 
 void CrashTab(TabContents* tab) {
   RenderProcessHost* rph = tab->render_view_host()->process();
   base::KillProcess(rph->process().handle(), 0, false);
-  CrashedRenderProcessObserver crash_observer(rph);
+  SimpleNotificationObserver<RenderProcessHost>
+      crash_observer(NotificationType::RENDERER_PROCESS_CLOSED, rph);
 }
 
 }  // namespace ui_test_utils