First part of automated_ui_tests improvements....

First part of automated_ui_tests improvements.

- disable unreliable RestoreTab action
- make more command sync, waiting for their completion

TEST=none
BUG=21547, 21636
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26371

[huanr, 2009-09-11 22:28:28]

Whenever we convert an action in automated_ui_test.{h|cc} from async to sync,
ideally we'd like to move the action to automated_ui_test_base.{h|cc} and write
an unit test in automated_ui_test_test.cc which is linked into ui_tests or
automated_ui_test_interactive_test.cc which is linked into interactive_ui_tests.
This way we can always verify individual actions are working properly on
buildbot before testing them in sequence.

[huanr, 2009-09-11 22:34:27]

Clarification: 
If an action is not covered by existing test cases in ui_tests, then moving it
to automated_ui_test_base and adding unit test are needed.
If an action is already covered by ui_tests, then it is optional. But then in
this case, it is straightforward to add unit tests anyway.

On 2009/09/11 22:28:28, huanr wrote:
> Whenever we convert an action in automated_ui_test.{h|cc} from async to sync,
> ideally we'd like to move the action to automated_ui_test_base.{h|cc} and
write
> an unit test in automated_ui_test_test.cc which is linked into ui_tests or
> automated_ui_test_interactive_test.cc which is linked into
interactive_ui_tests.
> This way we can always verify individual actions are working properly on
> buildbot before testing them in sequence.

[Paweł Hajdan Jr., 2009-09-15 17:59:40]

Patch updated.

[huanr, 2009-09-15 19:33:01]

LGTM!

http://codereview.chromium.org/196096/diff/1005/7006
File chrome/browser/automation/automation_provider.cc (right):

http://codereview.chromium.org/196096/diff/1005/7006#newcode772
Line 772: };
Let's keep an eye on corresponding tests in automated_ui_test_test for these
commands.

[Paweł Hajdan Jr., 2009-09-15 19:35:08]

I'll have to fix compile on Linux for this, so I'll send an updated patch
when I do that.

On Tue, Sep 15, 2009 at 12:33, <huanr@chromium.org> wrote:

> LGTM!
>
>
> http://codereview.chromium.org/196096/diff/1005/7006
> File chrome/browser/automation/automation_provider.cc (right):
>
> http://codereview.chromium.org/196096/diff/1005/7006#newcode772
> Line 772: };
> Let's keep an eye on corresponding tests in automated_ui_test_test for
> these commands.
>
>
> http://codereview.chromium.org/196096
>

[Paweł Hajdan Jr., 2009-09-15 22:06:06]

The fix was just to remove some #ifdefs, so I committed this.
On Tue, Sep 15, 2009 at 12:34, Pawe=C5=82 Hajdan Jr. <phajdan.jr@chromium.o=
rg>wrote:

> I'll have to fix compile on Linux for this, so I'll send an updated patch
> when I do that.
>
>
> On Tue, Sep 15, 2009 at 12:33, <huanr@chromium.org> wrote:
>
>> LGTM!
>>
>>
>> http://codereview.chromium.org/196096/diff/1005/7006
>> File chrome/browser/automation/automation_provider.cc (right):
>>
>> http://codereview.chromium.org/196096/diff/1005/7006#newcode772
>> Line 772: };
>> Let's keep an eye on corresponding tests in automated_ui_test_test for
>> these commands.
>>
>>
>> http://codereview.chromium.org/196096
>>
>
>

[Paweł Hajdan Jr., 2009-09-16 17:22:49]

I had to disable some tests on Linux and Mac, because automation hits
NOTIMPLEMENTED methods, which are non-trivial.

Please take a look.

[huanr, 2009-09-16 19:13:09]

LGTM