Issue 196068: Adding a --do-not-create-shortcuts icons command line switch to the installer to prev...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196068: Adding a --do-not-create-shortcuts icons command line switch to the installer to prev... (Closed)

Created:
11 years, 3 months ago by robertshield

Modified:
9 years, 6 months ago

Reviewers:
kuchhal

CC:
chromium-reviews_googlegroups.com, kuchhal

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Adding a --do-not-create-shortcuts command line switch to the installer to prevent it from trying to create Chrome desktop shortcuts. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25870

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -13 lines)			Patch
M	chrome/installer/setup/install.cc	View	1 chunk	+17 lines, -13 lines	0 comments	Download
MM	chrome/installer/setup/setup_util.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/installer/util/master_preferences.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/installer/util/master_preferences.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/installer/util/util_constants.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/installer/util/util_constants.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kuchhal

May be I am not clear about the usage so the following might not be ...

11 years, 3 months ago (2009-09-09 20:13:27 UTC) #2

kuchhal

11 years, 3 months ago (2009-09-09 20:31:04 UTC) #3

Based on offline conversation lgtm.

On Wed, Sep 9, 2009 at 1:13 PM, <kuchhal@chromium.org> wrote:

> May be I am not clear about the usage so the following might not be
> applicable.
>
> You want to completely hide Chrome on the machine when this flag is
> used, right? In that case it probably should be renamed. Also you would
> need to skip adding Uninstall entry in the registry.
>
>
> http://codereview.chromium.org/196068
>

Expand Messages | Collapse Messages